You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2019/03/11 19:08:25 UTC
Review Request 70185: Renamed Master::sendBulkOperationFeedback()
function.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70185/
-----------------------------------------------------------
Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
Repository: mesos
Description
-------
With the subsequent changes in this chain, this function
will not only send operation feedback but also adjust
metrics values, so the previous name was not appropriate
any more.
Diffs
-----
src/master/master.hpp 953cc5b8ab6a8e1920a3ad63fb2dd6382e3603ec
src/master/master.cpp dc68fc324de7242737123015fbac19a2129778ce
Diff: https://reviews.apache.org/r/70185/diff/1/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 70185: Renamed Master::sendBulkOperationFeedback()
function.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70185/
-----------------------------------------------------------
(Updated March 25, 2019, 11:38 a.m.)
Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
Changes
-------
Incorporated review feedback.
Repository: mesos
Description
-------
With the subsequent changes in this chain, this function
will not only send operation feedback but also adjust
metrics values, so the previous name was not appropriate
any more.
Diffs (updated)
-----
src/master/master.hpp ca2f8b147a3e17a0801b4c3e31ec1e995faebc07
src/master/master.cpp 9c4a9e83da94535873d72c902835f229c4f96320
Diff: https://reviews.apache.org/r/70185/diff/2/
Changes: https://reviews.apache.org/r/70185/diff/1-2/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 70185: Renamed Master::sendBulkOperationFeedback()
function.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70185/#review213728
-----------------------------------------------------------
Fix it, then Ship it!
src/master/master.hpp
Line 940 (original), 940 (patched)
<https://reviews.apache.org/r/70185/#comment299704>
I might suggest:
"Transitions all operations on an agent to a target state."
- Greg Mann
On March 11, 2019, 7:08 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70185/
> -----------------------------------------------------------
>
> (Updated March 11, 2019, 7:08 p.m.)
>
>
> Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> With the subsequent changes in this chain, this function
> will not only send operation feedback but also adjust
> metrics values, so the previous name was not appropriate
> any more.
>
>
> Diffs
> -----
>
> src/master/master.hpp 953cc5b8ab6a8e1920a3ad63fb2dd6382e3603ec
> src/master/master.cpp dc68fc324de7242737123015fbac19a2129778ce
>
>
> Diff: https://reviews.apache.org/r/70185/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>