[GitHub] [incubator-doris] morningman commented on a change in pull request #4719: [Bug] Add regular column when materialized slot is empty in tuple

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #4719:
URL: https://github.com/apache/incubator-doris/pull/4719#discussion_r503345164



##########
File path: fe/fe-core/src/main/java/org/apache/doris/planner/SingleNodePlanner.java
##########
@@ -1902,7 +1902,7 @@ private void materializeTableResultForCrossJoinOrCountStar(TableRef tblRef, Anal
      * @param analyzer
      */
     private void materializeBaseTableRefResultForCrossJoinOrCountStar(BaseTableRef tblRef, Analyzer analyzer) {

Review comment:
       I think this method name should be changed to a more common name?
   like: `materializeSlotForEmptyMaterializedTableRef()`?
   And add examples in comment to explain why we call it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org