You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/30 01:08:55 UTC

[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #2808: Use specialized dictionary kernels (#1178)

alamb commented on code in PR #2808:
URL: https://github.com/apache/arrow-datafusion/pull/2808#discussion_r910508235


##########
datafusion/expr/src/binary_rule.rs:
##########
@@ -155,14 +155,12 @@ pub fn comparison_eq_coercion(
     lhs_type: &DataType,
     rhs_type: &DataType,
 ) -> Option<DataType> {
-    // can't compare dictionaries directly due to
-    // https://github.com/apache/arrow-rs/issues/1201

Review Comment:
   ❤️ 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org