[GitHub] sijie commented on issue #791: Bookkeeper client allocates a lot of short-lived objects

[GitBox <gi...@apache.org>]

sijie commented on issue #791: Bookkeeper client allocates a lot of short-lived objects
URL: https://github.com/apache/bookkeeper/issues/791#issuecomment-382848831
 
 
   @nicmichael - I see your idea behind this, that is very smart. you are basically trading one memory copy with unpooled structure, so that you can use `UnsafeByteOperation` in protobuf. that is smart.
   
   one suggestion for you around digest manager: I would suggest it takes a flag on whether it is a v2 or v3 protocol. if it is v2 protocol, it is better to use pooled buffer; if it is v3 protocol, use Unpooled. in this way, you can keep the behavior unchanged for v2 protocol and reduce the memory copy for v3 protocol.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services