[GitHub] [arrow-rs] alamb commented on a change in pull request #307: ensure null-counts are written for all-null columns

[GitBox <gi...@apache.org>]

alamb commented on a change in pull request #307:
URL: https://github.com/apache/arrow-rs/pull/307#discussion_r634779074



##########
File path: parquet/src/arrow/arrow_writer.rs
##########
@@ -1560,4 +1560,21 @@ mod tests {
             panic!("Statistics::Int64 missing")
         }
     }
+
+    #[test]

Review comment:
       I would say this looks more like an "integration" test rather than "unit" test (in the sense that you connect some higher level APIs and ensure the output is reasonable). I personally don't see any problems with this approach. 
   
   to remove the dependency on Arrow you would probably have to use the `SerializedFileWriter` API directly: https://docs.rs/parquet/4.0.0/parquet/file/writer/trait.FileWriter.html
   
   But I think that would end up being quite a bit more code
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org