You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/08/10 00:00:33 UTC
[GitHub] [ozone] fapifta opened a new pull request #2516: HDDS-5561. EC: ECReplicationConfig should be immutable
fapifta opened a new pull request #2516:
URL: https://github.com/apache/ozone/pull/2516
## What changes were proposed in this pull request?
Just as other ReplicationConfig implementations, the ECReplicationConfig class should not expose setters, and should be immutable.
There aren't any setter usages yet, and it does not seem to be any reason to leave this class mutable, in case we need it we can add it back later on, when there is a reason for it to become mutable.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5561
Please replace this section with the link to the Apache JIRA)
## How was this patch tested?
No particular tests were run, IDEA did not found any use of these methods, and the patch just removes them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] fapifta commented on pull request #2516: HDDS-5561. EC: ECReplicationConfig should be immutable
Posted by GitBox <gi...@apache.org>.
fapifta commented on pull request #2516:
URL: https://github.com/apache/ozone/pull/2516#issuecomment-896125626
Thank you for the review @cxorm and for the offline review for @umamaheswararao. I merged the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] fapifta merged pull request #2516: HDDS-5561. EC: ECReplicationConfig should be immutable
Posted by GitBox <gi...@apache.org>.
fapifta merged pull request #2516:
URL: https://github.com/apache/ozone/pull/2516
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org