You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@quickstep.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/09/02 20:08:20 UTC
[jira] [Commented] (QUICKSTEP-53) New representation and faster
comparison operators for DateLit
[ https://issues.apache.org/jira/browse/QUICKSTEP-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15459469#comment-15459469 ]
ASF GitHub Bot commented on QUICKSTEP-53:
-----------------------------------------
GitHub user hakanmemisoglu opened a pull request:
https://github.com/apache/incubator-quickstep/pull/98
QUICKSTEP-53 DateLit improvements
This PR changes DateLit represantation:
- Encode year, month and day information into an u32 field instead of keeping them separate in three different fields. The change reduces the size of DateLit from 48 bits to 32 bits.
- With the internal representation change, we changed the comparison operators' implementation. They now use one unsigned integer comparison for each method.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-quickstep date-representation
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-quickstep/pull/98.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #98
----
commit 3c8708dfd0987b3491bcabb94e77dd95ea0aea10
Author: Harshad Deshmukh <hb...@apache.org>
Date: 2016-08-29T19:03:52Z
Separate Date type from Datetime type.
- Beginning from the parser to the operator execution level, treat Date type
sepearately than the Datetime type.
- Provide support for the extract function when applied on the Date
type, implemented in the DateExtractOperation.
- Modified the tests.
commit 998994eee67774d24b4a31a8aea3b1924b0e04ea
Author: Hakan Memisoglu <ha...@gmail.com>
Date: 2016-09-02T19:53:47Z
New representation and comparison operators for DateLit.
----
> New representation and faster comparison operators for DateLit
> --------------------------------------------------------------
>
> Key: QUICKSTEP-53
> URL: https://issues.apache.org/jira/browse/QUICKSTEP-53
> Project: Apache Quickstep
> Issue Type: Improvement
> Components: Types
> Reporter: Hakan Memisoglu
> Assignee: Hakan Memisoglu
>
> DateLit structure contains 3 member:
> 32i for year,
> 8u for month,
> 8u for day.
> Instead we can put all year, month, and day information into 32u. It will benefit from having a smaller sized representation.
> The new representation also provide faster comparison operator by directly using 32u comparison operators that have corresponding assembly primitives (instead of using if else branches).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)