[GitHub] [iotdb] qiaojialin commented on a change in pull request #5115: [IoTDB-2604] batch size is invalid in import-csv tool

[GitBox <gi...@apache.org>]

qiaojialin commented on a change in pull request #5115:
URL: https://github.com/apache/iotdb/pull/5115#discussion_r813891464



##########
File path: cli/src/main/java/org/apache/iotdb/tool/ImportCsv.java
##########
@@ -455,7 +455,7 @@ private static void writeDataAlignedByDevice(
             writeAndEmptyDataSet(
                 deviceName.get(), times, typesList, valuesList, measurementsList, 3);
             deviceName.set(record.get(1));
-          } else if (record.getRecordNumber() - 1 % BATCH_SIZE == 0 && times.size() != 0) {
+          } else if (times.size() >= BATCH_SIZE && times.size() != 0) {

Review comment:
       ```suggestion
             } else if (times.size() >= BATCH_SIZE) {
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org