You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by ta...@apache.org on 2019/08/07 05:01:15 UTC

[impala] branch master updated: IMPALA-8781: Fix TestResultSpooling::test_multi_batches

This is an automated email from the ASF dual-hosted git repository.

tarmstrong pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git


The following commit(s) were added to refs/heads/master by this push:
     new e849855  IMPALA-8781: Fix TestResultSpooling::test_multi_batches
e849855 is described below

commit e849855b232660d418dd5e226221bfc853b1ad9c
Author: Sahil Takiar <ta...@gmail.com>
AuthorDate: Tue Aug 6 14:37:17 2019 -0700

    IMPALA-8781: Fix TestResultSpooling::test_multi_batches
    
    Prefix the query in TestResultSpooling::test_multi_batches with the
    database name. This was causing the Dockerized tests to fail. I double
    checked what other tests do and all the ones I saw either switch to the
    appropriate database or prefix the table name using the database name.
    The latter seemed more straightforward.
    
    I was not able to re-produce this locally, and its odd that this only
    affected the Dockerized tests (even more odd is that it seems to either
    be intermittent, or only affecting Dockerized tests triggered by
    gerrit-verify-dryrun-external). Regardless, it is a straightforward fix
    that makes the TestResultSpooling::test_multi_batches consistent with
    the rest of the tests.
    
    Testing:
    * Ran test_result_spooling.py locally using both bin/impala-py.test
    and tests/run-tests.py.
    
    Change-Id: I939eedba37003f5c720cea96e5c3532e2cc6312c
    Reviewed-on: http://gerrit.cloudera.org:8080/14022
    Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 tests/query_test/test_result_spooling.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/query_test/test_result_spooling.py b/tests/query_test/test_result_spooling.py
index 470ad45..0ce541c 100644
--- a/tests/query_test/test_result_spooling.py
+++ b/tests/query_test/test_result_spooling.py
@@ -48,8 +48,8 @@ class TestResultSpooling(ImpalaTestSuite):
     """Validates that reading multiple row batches works when result spooling is
     enabled."""
     vector.get_value('exec_option')['batch_size'] = 10
-    self.validate_query("select id from alltypes order by id limit 1000",
-        vector.get_value('exec_option'))
+    self.validate_query("select id from functional_parquet.alltypes order by id "
+                        "limit 1000", vector.get_value('exec_option'))
 
   def validate_query(self, query, exec_options):
     """Compares the results of the given query with and without result spooling