You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/04/14 19:06:38 UTC
[GitHub] [beam] suztomo opened a new pull request, #17375: [BEAM-8691] Declare newer google-cloud-bigtable explicitly
suztomo opened a new pull request, #17375:
URL: https://github.com/apache/beam/pull/17375
com.google.cloud.bigtable:bigtable-client-core is a library
for an implementation deatil of bigtable access. For Java 7
support, the library declares old version of google-cloud-bigtable
library. However the old version does not work with latest GAX
library. Beam users would face AbstractMethodError.
By explicitly declaring google-cloud-bigtable at this module, we
ensure that Beam users get newer version of google-cloud-bigtable
that is compatible with latest GAX library.
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] suztomo commented on pull request #17375: [BEAM-8691] Declare newer google-cloud-bigtable explicitly
Posted by GitBox <gi...@apache.org>.
suztomo commented on PR #17375:
URL: https://github.com/apache/beam/pull/17375#issuecomment-1099733228
# Dataflow Java Post Commit Tests
Dataflow Java Post Commit Tests has been failing before this PR:
<img width="602" alt="Screen Shot 2022-04-14 at 8 06 33 PM" src="https://user-images.githubusercontent.com/28604/163495608-f9365392-91e4-4c25-b95a-50c78f9a3836.png">
# Dataflow V2 Java Post Commit Tests
Dataflow V2 Java Post Commit Tests has been failing before this PR:
<img width="596" alt="Screen Shot 2022-04-14 at 8 07 50 PM" src="https://user-images.githubusercontent.com/28604/163495677-c54a6f35-cf38-44dc-9b9c-26a7bcf1c553.png">
# SQL PreCommit
SQL PreCommit failed again with the same error message:
```
17:37:06 * What went wrong:
17:37:06 Execution failed for task ':runners:flink:1.14:job-server:shadowJar'.
17:37:06 > Failed to load cache entry for task ':runners:flink:1.14:job-server:shadowJar'
```
Will retry.
# Java PreCommit
Java precommit failed.
```
18:17:47 * What went wrong:
18:17:47 Execution failed for task ':sdks:java:io:google-cloud-platform:analyzeClassesDependencies'.
18:17:47 > Dependency analysis found issues.
18:17:47 unusedDeclaredArtifacts
18:17:47 - com.google.cloud:google-cloud-bigtable:2.5.3@jar
```
I need to fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] suztomo commented on pull request #17375: [BEAM-8691] Declare newer google-cloud-bigtable explicitly
Posted by GitBox <gi...@apache.org>.
suztomo commented on PR #17375:
URL: https://github.com/apache/beam/pull/17375#issuecomment-1099591609
Run PostCommit_Java_DataflowV2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] suztomo commented on pull request #17375: [BEAM-8691] Declare newer google-cloud-bigtable explicitly
Posted by GitBox <gi...@apache.org>.
suztomo commented on PR #17375:
URL: https://github.com/apache/beam/pull/17375#issuecomment-1099779702
39 successful, 1 skipped, and 1 failing checks. Onlyl CommunityMetrics is failing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] suztomo commented on pull request #17375: [BEAM-8691] Declare newer google-cloud-bigtable explicitly
Posted by GitBox <gi...@apache.org>.
suztomo commented on PR #17375:
URL: https://github.com/apache/beam/pull/17375#issuecomment-1099591502
Run PostCommit_Java_Dataflow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] suztomo merged pull request #17375: [BEAM-8691] Declare newer google-cloud-bigtable explicitly
Posted by GitBox <gi...@apache.org>.
suztomo merged PR #17375:
URL: https://github.com/apache/beam/pull/17375
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #17375: [BEAM-8691] Declare newer google-cloud-bigtable explicitly
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #17375:
URL: https://github.com/apache/beam/pull/17375#issuecomment-1099579828
# [Codecov](https://codecov.io/gh/apache/beam/pull/17375?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17375](https://codecov.io/gh/apache/beam/pull/17375?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7535e31) into [master](https://codecov.io/gh/apache/beam/commit/777cf4ab9d4809f34210e56e645cc7ee62092532?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (777cf4a) will **increase** coverage by `0.06%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #17375 +/- ##
==========================================
+ Coverage 73.69% 73.76% +0.06%
==========================================
Files 685 686 +1
Lines 89898 90125 +227
==========================================
+ Hits 66254 66484 +230
+ Misses 22474 22471 -3
Partials 1170 1170
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `83.68% <ø> (+0.06%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/17375?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/17375/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `89.06% <0.00%> (-0.48%)` | :arrow_down: |
| [sdks/python/apache\_beam/transforms/combiners.py](https://codecov.io/gh/apache/beam/pull/17375/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9jb21iaW5lcnMucHk=) | `93.03% <0.00%> (-0.39%)` | :arrow_down: |
| [.../apache\_beam/io/gcp/datastore/v1new/datastoreio.py](https://codecov.io/gh/apache/beam/pull/17375/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2RhdGFzdG9yZS92MW5ldy9kYXRhc3RvcmVpby5weQ==) | `86.16% <0.00%> (-0.29%)` | :arrow_down: |
| [...he\_beam/runners/interactive/sql/beam\_sql\_magics.py](https://codecov.io/gh/apache/beam/pull/17375/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9zcWwvYmVhbV9zcWxfbWFnaWNzLnB5) | `49.51% <0.00%> (-0.24%)` | :arrow_down: |
| [...apache\_beam/runners/dataflow/internal/apiclient.py](https://codecov.io/gh/apache/beam/pull/17375/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9hcGljbGllbnQucHk=) | `77.36% <0.00%> (-0.21%)` | :arrow_down: |
| [.../runners/portability/fn\_api\_runner/translations.py](https://codecov.io/gh/apache/beam/pull/17375/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3RyYW5zbGF0aW9ucy5weQ==) | `92.98% <0.00%> (-0.20%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/17375/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5) | `86.18% <0.00%> (-0.04%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/shared.py](https://codecov.io/gh/apache/beam/pull/17375/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvc2hhcmVkLnB5) | `100.00% <0.00%> (ø)` | |
| [...ython/apache\_beam/runners/interactive/sql/utils.py](https://codecov.io/gh/apache/beam/pull/17375/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9zcWwvdXRpbHMucHk=) | `76.09% <0.00%> (ø)` | |
| [...on/apache\_beam/runners/dataflow/dataflow\_runner.py](https://codecov.io/gh/apache/beam/pull/17375/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9kYXRhZmxvd19ydW5uZXIucHk=) | `82.89% <0.00%> (ø)` | |
| ... and [16 more](https://codecov.io/gh/apache/beam/pull/17375/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/17375?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/17375?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [777cf4a...7535e31](https://codecov.io/gh/apache/beam/pull/17375?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] suztomo commented on pull request #17375: [BEAM-8691] Declare newer google-cloud-bigtable explicitly
Posted by GitBox <gi...@apache.org>.
suztomo commented on PR #17375:
URL: https://github.com/apache/beam/pull/17375#issuecomment-1099591902
Run SQL Postcommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] emilymye commented on pull request #17375: [BEAM-8691] Declare newer google-cloud-bigtable explicitly
Posted by GitBox <gi...@apache.org>.
emilymye commented on PR #17375:
URL: https://github.com/apache/beam/pull/17375#issuecomment-1099653268
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] emilymye commented on pull request #17375: [BEAM-8691] Declare newer google-cloud-bigtable explicitly
Posted by GitBox <gi...@apache.org>.
emilymye commented on PR #17375:
URL: https://github.com/apache/beam/pull/17375#issuecomment-1099654308
Run SQL Postcommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] suztomo commented on pull request #17375: [BEAM-8691] Declare newer google-cloud-bigtable explicitly
Posted by GitBox <gi...@apache.org>.
suztomo commented on PR #17375:
URL: https://github.com/apache/beam/pull/17375#issuecomment-1099590115
CommunityMetrics is known to be failing for a while https://lists.apache.org/thread/5r8t14rkqb4r79x57ntnljy886ojxs2y
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] suztomo commented on pull request #17375: [BEAM-8691] Declare newer google-cloud-bigtable explicitly
Posted by GitBox <gi...@apache.org>.
suztomo commented on PR #17375:
URL: https://github.com/apache/beam/pull/17375#issuecomment-1099590639
Run SQL PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] suztomo commented on pull request #17375: [BEAM-8691] Declare newer google-cloud-bigtable explicitly
Posted by GitBox <gi...@apache.org>.
suztomo commented on PR #17375:
URL: https://github.com/apache/beam/pull/17375#issuecomment-1099591394
Run Java PostCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org