You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2021/09/27 17:00:03 UTC
[GitHub] [sling-org-apache-sling-jms] Akvel opened a new pull request #1: Convert XML config to Java-Config
Akvel opened a new pull request #1:
URL: https://github.com/apache/sling-org-apache-sling-jms/pull/1
I am testing my XML to Java-Config convertor on your project.
May be it would be interesting for you to merge results.
In any way plz you write any feed back in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-jms] joerghoh commented on a change in pull request #1: Convert XML config to Java-Config
Posted by GitBox <gi...@apache.org>.
joerghoh commented on a change in pull request #1:
URL: https://github.com/apache/sling-org-apache-sling-jms/pull/1#discussion_r717325485
##########
File path: pom.xml
##########
@@ -241,5 +241,18 @@
<version>1.10.19</version>
<scope>test</scope>
</dependency>
+
+ <dependency>
+ <groupId>org.eclipse.jetty.aggregate</groupId>
+ <artifactId>jetty-all</artifactId>
+ <version>8.1.22.v20160922</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.springframework</groupId>
+ <artifactId>spring-context</artifactId>
+ <version>5.3.9</version>
+ <scope>provided</scope>
Review comment:
So does this require to have spring-context and jetty-all within the OSGI container running? What kind of additional resource consumption (deployment size, heap) would that mean?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-jms] Akvel edited a comment on pull request #1: Convert XML config to Java-Config
Posted by GitBox <gi...@apache.org>.
Akvel edited a comment on pull request #1:
URL: https://github.com/apache/sling-org-apache-sling-jms/pull/1#issuecomment-928104264
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-jms] Akvel commented on a change in pull request #1: Convert XML config to Java-Config
Posted by GitBox <gi...@apache.org>.
Akvel commented on a change in pull request #1:
URL: https://github.com/apache/sling-org-apache-sling-jms/pull/1#discussion_r717373293
##########
File path: pom.xml
##########
@@ -241,5 +241,18 @@
<version>1.10.19</version>
<scope>test</scope>
</dependency>
+
+ <dependency>
+ <groupId>org.eclipse.jetty.aggregate</groupId>
+ <artifactId>jetty-all</artifactId>
+ <version>8.1.22.v20160922</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.springframework</groupId>
+ <artifactId>spring-context</artifactId>
+ <version>5.3.9</version>
+ <scope>provided</scope>
Review comment:
Currently you already has this dependencies in runtime. You get they from activemq.
They added as "provided" for fix compilation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-jms] bdelacretaz commented on pull request #1: Convert XML config to Java-Config
Posted by GitBox <gi...@apache.org>.
bdelacretaz commented on pull request #1:
URL: https://github.com/apache/sling-org-apache-sling-jms/pull/1#issuecomment-928916739
Thank you for this contribution. I don't think testing your XML to Java converter is sufficient motivation for us to make changes to this module, but if you have a need to functional changes or bug fixes, contributions are always welcome, of course!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-jms] joerghoh commented on a change in pull request #1: Convert XML config to Java-Config
Posted by GitBox <gi...@apache.org>.
joerghoh commented on a change in pull request #1:
URL: https://github.com/apache/sling-org-apache-sling-jms/pull/1#discussion_r717325485
##########
File path: pom.xml
##########
@@ -241,5 +241,18 @@
<version>1.10.19</version>
<scope>test</scope>
</dependency>
+
+ <dependency>
+ <groupId>org.eclipse.jetty.aggregate</groupId>
+ <artifactId>jetty-all</artifactId>
+ <version>8.1.22.v20160922</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.springframework</groupId>
+ <artifactId>spring-context</artifactId>
+ <version>5.3.9</version>
+ <scope>provided</scope>
Review comment:
So does this require to have spring-context and jetty-all within the OSGI container running? What kind of additional resource consumption (deployment size, heap) would that mean?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-jms] Akvel edited a comment on pull request #1: Convert XML config to Java-Config
Posted by GitBox <gi...@apache.org>.
Akvel edited a comment on pull request #1:
URL: https://github.com/apache/sling-org-apache-sling-jms/pull/1#issuecomment-928104264
I have not idea why continuous-integration/jenkins/pr-merge failed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-jms] Akvel commented on a change in pull request #1: Convert XML config to Java-Config
Posted by GitBox <gi...@apache.org>.
Akvel commented on a change in pull request #1:
URL: https://github.com/apache/sling-org-apache-sling-jms/pull/1#discussion_r717373293
##########
File path: pom.xml
##########
@@ -241,5 +241,18 @@
<version>1.10.19</version>
<scope>test</scope>
</dependency>
+
+ <dependency>
+ <groupId>org.eclipse.jetty.aggregate</groupId>
+ <artifactId>jetty-all</artifactId>
+ <version>8.1.22.v20160922</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.springframework</groupId>
+ <artifactId>spring-context</artifactId>
+ <version>5.3.9</version>
+ <scope>provided</scope>
Review comment:
Currently you already has this dependencies in runtime. You get they from activemq.
They added as "provided" for fix compilation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-jms] bdelacretaz commented on pull request #1: Convert XML config to Java-Config
Posted by GitBox <gi...@apache.org>.
bdelacretaz commented on pull request #1:
URL: https://github.com/apache/sling-org-apache-sling-jms/pull/1#issuecomment-928916739
Thank you for this contribution. I don't think testing your XML to Java converter is sufficient motivation for us to make changes to this module, but if you have a need to functional changes or bug fixes, contributions are always welcome, of course!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-jms] Akvel commented on pull request #1: Convert XML config to Java-Config
Posted by GitBox <gi...@apache.org>.
Akvel commented on pull request #1:
URL: https://github.com/apache/sling-org-apache-sling-jms/pull/1#issuecomment-928104264
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-jms] Akvel commented on pull request #1: Convert XML config to Java-Config
Posted by GitBox <gi...@apache.org>.
Akvel commented on pull request #1:
URL: https://github.com/apache/sling-org-apache-sling-jms/pull/1#issuecomment-928104264
I have not idea why continuous-integration/jenkins/pr-merge can not passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-jms] Akvel edited a comment on pull request #1: Convert XML config to Java-Config
Posted by GitBox <gi...@apache.org>.
Akvel edited a comment on pull request #1:
URL: https://github.com/apache/sling-org-apache-sling-jms/pull/1#issuecomment-928997546
> Thank you for this contribution. I don't think testing your XML to Java converter is sufficient motivation for us to make changes to this module, but if you have a need to functional changes or bug fixes, contributions are always welcome, of course!
Np. If you ready apply moving from XML to Java Configs I am ready to add some not major changes manually to PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-jms] Akvel commented on pull request #1: Convert XML config to Java-Config
Posted by GitBox <gi...@apache.org>.
Akvel commented on pull request #1:
URL: https://github.com/apache/sling-org-apache-sling-jms/pull/1#issuecomment-928997546
> Thank you for this contribution. I don't think testing your XML to Java converter is sufficient motivation for us to make changes to this module, but if you have a need to functional changes or bug fixes, contributions are always welcome, of course!
Np. If you ready apply moving from XML to Java Configs I am ready to do add some not major changes manually to PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org