You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Veena Basavaraj <vb...@cloudera.com> on 2015/01/08 00:29:57 UTC
Review Request 29683: Avro IDF class and unit tests
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29683/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-1902
https://issues.apache.org/jira/browse/SQOOP-1902
Repository: sqoop-sqoop2
Description
-------
see jira and the design wiki
https://cwiki.apache.org/confluence/display/SQOOP/Avro+Intermediate+Data+Format
Diffs
-----
connector/connector-sdk/pom.xml 46cb9f8
connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/SqoopAvroUtils.java PRE-CREATION
connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/SqoopIDFUtils.java 979aa4f
connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/AVROIntermediateDataFormat.java PRE-CREATION
connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/AVROIntermediateDataFormatError.java PRE-CREATION
connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java be1147d
connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormatError.java a88db45
connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/IntermediateDataFormat.java adeb2ec
connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/IntermediateDataFormatError.java bda75fc
connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/JSONIntermediateDataFormat.java 9329cf8
connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestAVROIntermediateDataFormat.java PRE-CREATION
pom.xml 4dbc48f
Diff: https://reviews.apache.org/r/29683/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj
Re: Review Request 29683: Avro IDF class and unit tests
Posted by Veena Basavaraj <vb...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29683/
-----------------------------------------------------------
(Updated Jan. 7, 2015, 5:57 p.m.)
Review request for Sqoop.
Bugs: SQOOP-1902
https://issues.apache.org/jira/browse/SQOOP-1902
Repository: sqoop-sqoop2
Description
-------
see jira and the design wiki
https://cwiki.apache.org/confluence/display/SQOOP/Avro+Intermediate+Data+Format
Diffs (updated)
-----
connector/connector-sdk/pom.xml 46cb9f8
connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/SqoopAvroUtils.java PRE-CREATION
connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/SqoopIDFUtils.java 979aa4f
connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/AVROIntermediateDataFormat.java PRE-CREATION
connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/AVROIntermediateDataFormatError.java PRE-CREATION
connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java be1147d
connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormatError.java a88db45
connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/IntermediateDataFormat.java adeb2ec
connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/IntermediateDataFormatError.java bda75fc
connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/JSONIntermediateDataFormat.java 9329cf8
connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestAVROIntermediateDataFormat.java PRE-CREATION
pom.xml 4dbc48f
Diff: https://reviews.apache.org/r/29683/diff/
Testing
-------
yes
Thanks,
Veena Basavaraj
Re: Review Request 29683: Avro IDF class and unit tests
Posted by Veena Basavaraj <vb...@cloudera.com>.
> On Jan. 7, 2015, 5:42 p.m., Abraham Elmahrek wrote:
> > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/SqoopIDFUtils.java, lines 358-369
> > <https://reviews.apache.org/r/29683/diff/1/?file=809677#file809677line358>
> >
> > Is this used?
ah I moved it from the JSONIDF. let me clean up JSON IDF.
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29683/#review67141
-----------------------------------------------------------
On Jan. 7, 2015, 3:29 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29683/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2015, 3:29 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1902
> https://issues.apache.org/jira/browse/SQOOP-1902
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see jira and the design wiki
> https://cwiki.apache.org/confluence/display/SQOOP/Avro+Intermediate+Data+Format
>
>
> Diffs
> -----
>
> connector/connector-sdk/pom.xml 46cb9f8
> connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/SqoopAvroUtils.java PRE-CREATION
> connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/SqoopIDFUtils.java 979aa4f
> connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/AVROIntermediateDataFormat.java PRE-CREATION
> connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/AVROIntermediateDataFormatError.java PRE-CREATION
> connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java be1147d
> connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormatError.java a88db45
> connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/IntermediateDataFormat.java adeb2ec
> connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/IntermediateDataFormatError.java bda75fc
> connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/JSONIntermediateDataFormat.java 9329cf8
> connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestAVROIntermediateDataFormat.java PRE-CREATION
> pom.xml 4dbc48f
>
> Diff: https://reviews.apache.org/r/29683/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>
Re: Review Request 29683: Avro IDF class and unit tests
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29683/#review67141
-----------------------------------------------------------
Ship it!
A few nits. LGTM.
connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/SqoopIDFUtils.java
<https://reviews.apache.org/r/29683/#comment110998>
Is this used?
connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormatError.java
<https://reviews.apache.org/r/29683/#comment110989>
0004?
connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/IntermediateDataFormatError.java
<https://reviews.apache.org/r/29683/#comment110991>
0004?
- Abraham Elmahrek
On Jan. 7, 2015, 11:29 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29683/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2015, 11:29 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1902
> https://issues.apache.org/jira/browse/SQOOP-1902
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see jira and the design wiki
> https://cwiki.apache.org/confluence/display/SQOOP/Avro+Intermediate+Data+Format
>
>
> Diffs
> -----
>
> connector/connector-sdk/pom.xml 46cb9f8
> connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/SqoopAvroUtils.java PRE-CREATION
> connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/SqoopIDFUtils.java 979aa4f
> connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/AVROIntermediateDataFormat.java PRE-CREATION
> connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/AVROIntermediateDataFormatError.java PRE-CREATION
> connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormat.java be1147d
> connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/CSVIntermediateDataFormatError.java a88db45
> connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/IntermediateDataFormat.java adeb2ec
> connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/IntermediateDataFormatError.java bda75fc
> connector/connector-sdk/src/main/java/org/apache/sqoop/connector/idf/JSONIntermediateDataFormat.java 9329cf8
> connector/connector-sdk/src/test/java/org/apache/sqoop/connector/idf/TestAVROIntermediateDataFormat.java PRE-CREATION
> pom.xml 4dbc48f
>
> Diff: https://reviews.apache.org/r/29683/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Veena Basavaraj
>
>