You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/07/15 19:24:42 UTC
[GitHub] [airflow] kaxil opened a new pull request #9844: Replace deprecated SQL operators
kaxil opened a new pull request #9844:
URL: https://github.com/apache/airflow/pull/9844
Operators in `from airflow.operators.check_operator import *` are deprecated
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Target Github ISSUE in description if exists
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #9844: Replace deprecated SQL operators
Posted by GitBox <gi...@apache.org>.
eladkal commented on pull request #9844:
URL: https://github.com/apache/airflow/pull/9844#issuecomment-658998465
@mik-laj @kaxil correct me if I'm wrong here but if this is merged it may cause issues for future releases of backport packages for users who run older versions of Airflow.
This change is based on https://github.com/apache/airflow/pull/9124 which was released in Airflow 1.10.11
so if you merge this PR now any future release of druid/qouble/bigquery in backport package will include this PR causing the changed operators to not work as `airflow.operators.sql` doesn't exist for users who run version < 1.1.11
Since this PR doesn't really introduce new functionality maybe it would be better to wait with this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #9844: Replace deprecated SQL operators
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #9844:
URL: https://github.com/apache/airflow/pull/9844#issuecomment-658965466
You should also add refactoring with bower so that the backport packages build properly. To be honest, I wanted to make this change earlier, but because of my laziness I didn't do it. We can do it quickly in the future, when we stop releasing new packages, and now making this change is little problematic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #9844: Replace deprecated SQL operators
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #9844:
URL: https://github.com/apache/airflow/pull/9844#issuecomment-658968171
No, no...Please re-open and add this PR to Airflow 2.0 milestone. We will merge it at the right time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj edited a comment on pull request #9844: Replace deprecated SQL operators
Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on pull request #9844:
URL: https://github.com/apache/airflow/pull/9844#issuecomment-659002114
@eladkal We can also write Bowler code that will make changes to backport packages. However, this will require additional work. On the other hand, waiting is free.
https://github.com/apache/airflow/blob/master/backport_packages/refactor_backport_packages.py#L121-L149
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil closed pull request #9844: Replace deprecated SQL operators
Posted by GitBox <gi...@apache.org>.
kaxil closed pull request #9844:
URL: https://github.com/apache/airflow/pull/9844
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] stale[bot] commented on pull request #9844: Replace deprecated SQL operators
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #9844:
URL: https://github.com/apache/airflow/pull/9844#issuecomment-683489433
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #9844: Replace deprecated SQL operators
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #9844:
URL: https://github.com/apache/airflow/pull/9844#issuecomment-658999403
> @mik-laj @kaxil correct me if I'm wrong here but if this is merged it may cause issues for future releases of backport packages for users who run older versions of Airflow.
>
> This change is based on #9124 which was released in Airflow 1.10.11
> so if you merge this PR now any future release of druid/qouble/bigquery in backport package will include this PR causing the changed operators to not work as `airflow.operators.sql` doesn't exist for users who run version < 1.1.11
>
> Since this PR doesn't really introduce new functionality maybe it would be better to wait with this?
That's correct, hence we have added it to 2.0 milestone. So it won't be merged before that to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #9844: Replace deprecated SQL operators
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #9844:
URL: https://github.com/apache/airflow/pull/9844#issuecomment-707058699
> We have to wait for a good moment with this change.
Yup no problem
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #9844: Replace deprecated SQL operators
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #9844:
URL: https://github.com/apache/airflow/pull/9844#issuecomment-658966661
> You should also add refactoring with bower so that the backport packages build properly. To be honest, I wanted to make this change earlier, but because of my laziness I didn't do it. We can do it quickly in the future, when we stop releasing new packages, and now making this change is little problematic.
Sure in that case I will close the PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #9844: Replace deprecated SQL operators
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #9844:
URL: https://github.com/apache/airflow/pull/9844#issuecomment-659205777
@eladkal -> yes. we've done few refactorings like that already and we have few more - including releasing cncf.kubernetes backport packages. And that's the reason of the backport package "test" to make sure that what we have at least imports in 1.10.* series so that we do not introduce backwards-incompatible changes.
So the safety net we have works :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #9844: Replace deprecated SQL operators
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #9844:
URL: https://github.com/apache/airflow/pull/9844#issuecomment-658970092
Done 😄
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #9844: Replace deprecated SQL operators
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #9844:
URL: https://github.com/apache/airflow/pull/9844#issuecomment-659002114
@eladkal We can also write Bowler code that will make changes to backport packages.
https://github.com/apache/airflow/blob/master/backport_packages/refactor_backport_packages.py#L121-L149
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb closed pull request #9844: Replace deprecated SQL operators
Posted by GitBox <gi...@apache.org>.
ashb closed pull request #9844:
URL: https://github.com/apache/airflow/pull/9844
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org