You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by manishgupta88 <gi...@git.apache.org> on 2018/06/21 06:03:09 UTC

[GitHub] carbondata pull request #2389: [CARBONDATA-2623][DataMap] Add DataMap pre an...

Github user manishgupta88 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2389#discussion_r197019227
  
    --- Diff: integration/spark2/src/main/scala/org/apache/carbondata/spark/rdd/CarbonTableCompactor.scala ---
    @@ -272,6 +284,13 @@ class CarbonTableCompactor(carbonLoadModel: CarbonLoadModel,
             mergedLoadName)
           OperationListenerBus.getInstance()
             .fireEvent(compactionLoadStatusPostEvent, operationContext)
    +      if (null != tableDataMaps) {
    +        val buildDataMapPostExecutionEvent: BuildDataMapPostExecutionEvent =
    +          new BuildDataMapPostExecutionEvent(sqlContext.sparkSession,
    --- End diff --
    
    Above LoadDataMapPreExecutionEvent is used and here BuildDataMapPostExecutionEvent is used. Check if this is correct. I think above it should be BuildDataMapPreExecutionEvent OR here it should be LoadDataMapPostExecutionEvent 


---