You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jason Huynh <hu...@gmail.com> on 2016/04/05 00:14:05 UTC
Review Request 45709: GEODE-1062: removing similar/duplicate create
receiver methods
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45709/
-----------------------------------------------------------
Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan Smith, and xiaojian zhou.
Repository: geode
Description
-------
There are two other methods in WanTestBase that can now be removed as they do the same exact thing as createReceiver
Diffs
-----
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java 6685451
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/concurrent/ConcurrentWANPropogation_1_DUnitTest.java b95437c
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/misc/ShutdownAllPersistentGatewaySenderDUnitTest.java f821ab1
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialGatewaySenderDistributedDeadlockDUnitTest.java 93979f0
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialGatewaySenderQueueDUnitTest.java d77fdcf
geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialWANPropogationDUnitTest.java 55f1ac1
Diff: https://reviews.apache.org/r/45709/diff/
Testing
-------
Thanks,
Jason Huynh
Re: Review Request 45709: GEODE-1062: removing similar/duplicate
create receiver methods
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45709/#review126986
-----------------------------------------------------------
Ship it!
Ship It!
- Dan Smith
On April 4, 2016, 10:14 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45709/
> -----------------------------------------------------------
>
> (Updated April 4, 2016, 10:14 p.m.)
>
>
> Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan Smith, and xiaojian zhou.
>
>
> Repository: geode
>
>
> Description
> -------
>
> There are two other methods in WanTestBase that can now be removed as they do the same exact thing as createReceiver
>
>
> Diffs
> -----
>
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java 6685451
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/concurrent/ConcurrentWANPropogation_1_DUnitTest.java b95437c
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/misc/ShutdownAllPersistentGatewaySenderDUnitTest.java f821ab1
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialGatewaySenderDistributedDeadlockDUnitTest.java 93979f0
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialGatewaySenderQueueDUnitTest.java d77fdcf
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialWANPropogationDUnitTest.java 55f1ac1
>
> Diff: https://reviews.apache.org/r/45709/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Huynh
>
>
Re: Review Request 45709: GEODE-1062: removing similar/duplicate
create receiver methods
Posted by Barry Oglesby <bo...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45709/#review126989
-----------------------------------------------------------
Ship it!
Ship It!
- Barry Oglesby
On April 4, 2016, 10:14 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45709/
> -----------------------------------------------------------
>
> (Updated April 4, 2016, 10:14 p.m.)
>
>
> Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan Smith, and xiaojian zhou.
>
>
> Repository: geode
>
>
> Description
> -------
>
> There are two other methods in WanTestBase that can now be removed as they do the same exact thing as createReceiver
>
>
> Diffs
> -----
>
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java 6685451
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/concurrent/ConcurrentWANPropogation_1_DUnitTest.java b95437c
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/misc/ShutdownAllPersistentGatewaySenderDUnitTest.java f821ab1
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialGatewaySenderDistributedDeadlockDUnitTest.java 93979f0
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialGatewaySenderQueueDUnitTest.java d77fdcf
> geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialWANPropogationDUnitTest.java 55f1ac1
>
> Diff: https://reviews.apache.org/r/45709/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Huynh
>
>