You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Artemy Tregubenko (JIRA)" <ji...@apache.org> on 2008/02/07 17:46:08 UTC
[jira] Created: (SHINDIG-54) /features/core/legacy.js:_gel()
doesn't actually accept elements, strings only
/features/core/legacy.js:_gel() doesn't actually accept elements, strings only
-------------------------------------------------------------------------------
Key: SHINDIG-54
URL: https://issues.apache.org/jira/browse/SHINDIG-54
Project: Shindig
Issue Type: Bug
Components: Features
Reporter: Artemy Tregubenko
Assignee: Kevin Brown
Priority: Minor
JsDoc of _gel function says it accepts objects. However it's implemented as
return document.getElementById ? document.getElementById(el) : null;
so it returns nulls for element parameter
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Created: (SHINDIG-54) /features/core/legacy.js:_gel() doesn't actually accept elements, strings only
Posted by Kevin Brown <et...@google.com>.
This is consistent with the actual legacy behavior; it's the documentation
that's wrong.
On Feb 7, 2008 8:46 AM, Artemy Tregubenko (JIRA) <ji...@apache.org> wrote:
> /features/core/legacy.js:_gel() doesn't actually accept elements, strings
> only
>
> -------------------------------------------------------------------------------
>
> Key: SHINDIG-54
> URL: https://issues.apache.org/jira/browse/SHINDIG-54
> Project: Shindig
> Issue Type: Bug
> Components: Features
> Reporter: Artemy Tregubenko
> Assignee: Kevin Brown
> Priority: Minor
>
>
> JsDoc of _gel function says it accepts objects. However it's implemented
> as
> return document.getElementById ? document.getElementById(el) : null;
> so it returns nulls for element parameter
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
[jira] Commented: (SHINDIG-54) /features/core/legacy.js:_gel()
doesn't actually accept elements, strings only
Posted by "Artemy Tregubenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12567046#action_12567046 ]
Artemy Tregubenko commented on SHINDIG-54:
------------------------------------------
Is there a way to correct documentation? It's generated from code comments, so file /features/core/legacy.js should be modified
> /features/core/legacy.js:_gel() doesn't actually accept elements, strings only
> -------------------------------------------------------------------------------
>
> Key: SHINDIG-54
> URL: https://issues.apache.org/jira/browse/SHINDIG-54
> Project: Shindig
> Issue Type: Bug
> Components: Features
> Reporter: Artemy Tregubenko
> Assignee: Kevin Brown
> Priority: Minor
>
> JsDoc of _gel function says it accepts objects. However it's implemented as
> return document.getElementById ? document.getElementById(el) : null;
> so it returns nulls for element parameter
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SHINDIG-54) /features/core/legacy.js:_gel() doesn't
actually accept elements, strings only
Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-54?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Brown closed SHINDIG-54.
------------------------------
Resolution: Won't Fix
This is a documentation error; _gel is intended to replicate the behavior of iGoogle, which only accepts strings.
> /features/core/legacy.js:_gel() doesn't actually accept elements, strings only
> -------------------------------------------------------------------------------
>
> Key: SHINDIG-54
> URL: https://issues.apache.org/jira/browse/SHINDIG-54
> Project: Shindig
> Issue Type: Bug
> Components: Features
> Reporter: Artemy Tregubenko
> Assignee: Kevin Brown
> Priority: Minor
>
> JsDoc of _gel function says it accepts objects. However it's implemented as
> return document.getElementById ? document.getElementById(el) : null;
> so it returns nulls for element parameter
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.