You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/09/09 18:49:34 UTC

[GitHub] [ignite-3] rpuch commented on a diff in pull request #1070: IGNITE-17621 Fixed registration already completed future in InFlightF…

rpuch commented on code in PR #1070:
URL: https://github.com/apache/ignite-3/pull/1070#discussion_r967374687


##########
modules/core/src/test/java/org/apache/ignite/internal/future/InFlightFuturesTest.java:
##########
@@ -40,6 +40,16 @@ void addsFutureToInFlightSetOnRegistration() {
         assertThat(currentFutures(inFlightFutures), is(singleton(incompleteFuture)));
     }
 
+
+    @Test
+    void addsAlreadyCompletedFutureToInFlightSet() {

Review Comment:
   The idea of the test seems to be to check that the future actually gets removed (not added). How about renaming the test method to `removesAlreadyCompletedFutureOnRegistration()`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org