[GitHub] [incubator-uniffle] kaijchen commented on a diff in pull request #1134: [#722] imporvement: Cleanup residue files in tmp directory after tests

["kaijchen (via GitHub)" <gi...@apache.org>]

kaijchen commented on code in PR #1134:
URL: https://github.com/apache/incubator-uniffle/pull/1134#discussion_r1299176499


##########
common/src/test/java/org/apache/uniffle/common/util/ChecksumUtilsTest.java:
##########
@@ -21,18 +21,27 @@
 import java.io.FileOutputStream;
 import java.nio.ByteBuffer;
 import java.nio.channels.FileChannel;
-import java.nio.file.Files;
 import java.nio.file.Path;
 import java.nio.file.Paths;
 import java.util.Random;
 import java.util.zip.CRC32;
 
+import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.io.TempDir;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 
 public class ChecksumUtilsTest {
 
+  @TempDir File tempDir;
+
+  @BeforeEach
+  void beforeEach() {
+    assertTrue(this.tempDir.isDirectory());
+  }
+

Review Comment:
   This beforeEach is not necessary.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org