[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1316: nimble/ll: Add vs command to change all data length parameters

[GitBox <gi...@apache.org>]

apache-mynewt-bot commented on PR #1316:
URL: https://github.com/apache/mynewt-nimble/pull/1316#issuecomment-1235242251

   
   <!-- style-bot -->
   
   ## Style check summary
   
   ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
   #### nimble/controller/src/ble_ll_hci.c
   <details>
   
   ```diff
   @@ -462,7 +463,7 @@
    static int
    ble_ll_hci_le_wr_sugg_data_len(const uint8_t *cmdbuf, uint8_t len)
    {
   -    const struct ble_hci_le_wr_sugg_def_data_len_cp *cmd = (const void*) cmdbuf;
   +    const struct ble_hci_le_wr_sugg_def_data_len_cp *cmd = (const void *) cmdbuf;
        uint16_t tx_octets;
        uint16_t tx_time;
    
   @@ -487,9 +488,9 @@
         * in which case we just use our max.
         */
        g_ble_ll_conn_params.conn_init_max_tx_octets =
   -                    min(tx_octets, g_ble_ll_conn_params.supp_max_tx_octets);
   +        min(tx_octets, g_ble_ll_conn_params.supp_max_tx_octets);
        g_ble_ll_conn_params.conn_init_max_tx_time =
   -                    min(tx_time, g_ble_ll_conn_params.supp_max_tx_time);
   +        min(tx_time, g_ble_ll_conn_params.supp_max_tx_time);
    
        /*
         * Use the same for coded and uncoded defaults. These are used when PHY
   @@ -497,10 +498,10 @@
         * host. Make sure we do not exceed max supported time on uncoded.
         */
        g_ble_ll_conn_params.conn_init_max_tx_time_uncoded =
   -                            min(BLE_LL_CONN_SUPP_TIME_MAX_UNCODED,
   +        min(BLE_LL_CONN_SUPP_TIME_MAX_UNCODED,
                                    g_ble_ll_conn_params.conn_init_max_tx_time);
        g_ble_ll_conn_params.conn_init_max_tx_time_coded =
   -                            g_ble_ll_conn_params.conn_init_max_tx_time;
   +        g_ble_ll_conn_params.conn_init_max_tx_time;
    
        return 0;
    }
   ```
   
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org