[GitHub] [incubator-uniffle] colinmjj commented on a diff in pull request #16: [Bug] Fix NPE problem when process the event if application was cleared already

[GitBox <gi...@apache.org>]

colinmjj commented on code in PR #16:
URL: https://github.com/apache/incubator-uniffle/pull/16#discussion_r912899523


##########
server/src/main/java/org/apache/uniffle/server/ShuffleFlushManager.java:
##########
@@ -285,7 +292,9 @@ void processPendingEvents() throws Exception {
           pendingEventTimeoutSec, event.getEvent());
       return;
     }
-    if (storage.canWrite()) {
+    // storage maybe null if the application cache was cleared already
+    // add event to flush queue, and it will be released
+    if (storage == null || storage.canWrite()) {

Review Comment:
   Event should be discarded and memory should be updated, these actions can't be finished here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org