You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/08/02 16:06:33 UTC

[GitHub] [incubator-yunikorn-scheduler-interface] updown321 opened a new pull request #43: Yunikorn-761. test the pre-commit action

updown321 opened a new pull request #43:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/43


   ### What is this PR for?
   testing Github actions
   
   
   ### What type of PR is it?
   * [ ] - Bug Fix
   * [x] - Improvement
   * [ ] - Feature
   * [ ] - Documentation
   * [ ] - Hot Fix
   * [ ] - Refactoring
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   * Open an issue on Jira https://issues.apache.org/jira/browse/YUNIKORN-761/
   * Put link here, and add [YUNIKORN-*Jira number*] in PR title, eg. `[YUNIKORN-2] Gang scheduling interface parameters`
   
   ### How should this be tested?
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * [ ] - The licenses files need update.
   * [ ] - There is breaking changes for older versions.
   * [ ] - It needs documentation.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-scheduler-interface] updown321 commented on pull request #43: Yunikorn-761. test the pre-commit action

Posted by GitBox <gi...@apache.org>.
updown321 commented on pull request #43:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/43#issuecomment-891138527


   I can run correct action when I push it, but still cannot trigger the action when PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-scheduler-interface] yangwwei commented on pull request #43: Yunikorn-761. test the pre-commit action

Posted by GitBox <gi...@apache.org>.
yangwwei commented on pull request #43:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/43#issuecomment-890042719


   @updown321 it is not triggering the github action run, any idea why?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-scheduler-interface] yangwwei merged pull request #43: [YUNIKORN-761] Add pre-commit action for scheduler-interface repo

Posted by GitBox <gi...@apache.org>.
yangwwei merged pull request #43:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/43


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-scheduler-interface] updown321 commented on pull request #43: Yunikorn-761. test the pre-commit action

Posted by GitBox <gi...@apache.org>.
updown321 commented on pull request #43:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/43#issuecomment-890350170


   > @updown321 it is not triggering the github action run, any idea why?
   
   I have not found it yet. still trying


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-scheduler-interface] wilfred-s commented on a change in pull request #43: Yunikorn-761. test the pre-commit action

Posted by GitBox <gi...@apache.org>.
wilfred-s commented on a change in pull request #43:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/43#discussion_r680637529



##########
File path: .github/workflows/main.yml
##########
@@ -0,0 +1,22 @@
+name: Pre-commit checks
+
+on:
+  pull_request:

Review comment:
       Should we not define which branch(es) this runs against?
   I would expect to see:
   ```
   on:
     pull_request:
       branches:
         - master
    ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-scheduler-interface] updown321 closed pull request #43: Yunikorn-761. test the pre-commit action

Posted by GitBox <gi...@apache.org>.
updown321 closed pull request #43:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/43


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-scheduler-interface] updown321 commented on a change in pull request #43: Yunikorn-761. test the pre-commit action

Posted by GitBox <gi...@apache.org>.
updown321 commented on a change in pull request #43:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/43#discussion_r681047754



##########
File path: .github/workflows/main.yml
##########
@@ -0,0 +1,22 @@
+name: Pre-commit checks
+
+on:
+  pull_request:

Review comment:
       yes, we need it. thank you!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org