[GitHub] [superset] betodealmeida commented on pull request #16250: fix: skip perms on query context update

[GitBox <gi...@apache.org>]

betodealmeida commented on pull request #16250:
URL: https://github.com/apache/superset/pull/16250#issuecomment-898587051


   > Looks good, but question for my understanding, why couldn't we give the machine user permission for the charts that it doesn't own?
   
   I think we'd need to add the machine user as an owner to all the charts in order to do that, which would require hooks for new charts, and could potentially be confusing to the user (why is "machine" also an owner of my chart?). It would also allow the machine user to delete or modify charts, while with the approach in this PR we only let it update `query_context`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org