[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #3289: sched: task: Fix to initialize the task-specific data

[GitBox <gi...@apache.org>]

patacongo commented on a change in pull request #3289:
URL: https://github.com/apache/incubator-nuttx/pull/3289#discussion_r606670479



##########
File path: sched/task/task_init.c
##########
@@ -137,6 +137,10 @@ int nxtask_init(FAR struct task_tcb_s *tcb, const char *name, int priority,
   group->tg_libvars = up_stack_frame(&tcb->cmn, sizeof(struct libvars_s));
   DEBUGASSERT(group->tg_libvars != NULL);
 
+  /* Initialize the task-specific data */
+
+  memset(group->tg_libvars, 0, sizeof(struct libvars_s));

Review comment:
       This clearing of the task-specific data should be performed by ALL architectures.  Hence, I think the memset should be moved into the OS.  Do you agree?  If so, let's close this and I will open another PR the does the memset for all architectures.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org