You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2018/01/09 20:18:08 UTC
[kudu-CR] [tests] update tests for replication scheme consistency
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8979
Change subject: [tests] update tests for replication scheme consistency
......................................................................
[tests] update tests for replication scheme consistency
Fixed and updated some scenarios once the re-replication scheme
consistency is enforced:
* MasterTest.TestRegisterAndHeartbeat scenario
* MasterReplicationTest.TestHeartbeatAcceptedByAnyMaster
* MasterCertAuthorityTest.RefuseToSignInvalidCSR
* MasterCertAuthorityTest.MasterLeaderSignsCSR
This is a follow-up for 1769eed53ee2c21a88a766cb72bf8c9ae622099d.
Change-Id: I8f5bbb581abeb3a781b522dff90711b2ffc988df
---
M src/kudu/integration-tests/master_cert_authority-itest.cc
M src/kudu/integration-tests/master_replication-itest.cc
M src/kudu/master/master-test.cc
3 files changed, 98 insertions(+), 22 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/79/8979/1
--
To view, visit http://gerrit.cloudera.org:8080/8979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8f5bbb581abeb3a781b522dff90711b2ffc988df
Gerrit-Change-Number: 8979
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [tests] update tests for replication scheme consistency
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8979 )
Change subject: [tests] update tests for replication scheme consistency
......................................................................
[tests] update tests for replication scheme consistency
Fixed and updated some scenarios once the re-replication scheme
consistency is enforced:
* MasterTest.TestRegisterAndHeartbeat scenario
* MasterReplicationTest.TestHeartbeatAcceptedByAnyMaster
* MasterCertAuthorityTest.RefuseToSignInvalidCSR
* MasterCertAuthorityTest.MasterLeaderSignsCSR
This is a follow-up for 1769eed53ee2c21a88a766cb72bf8c9ae622099d.
Change-Id: I8f5bbb581abeb3a781b522dff90711b2ffc988df
Reviewed-on: http://gerrit.cloudera.org:8080/8979
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/integration-tests/master_cert_authority-itest.cc
M src/kudu/integration-tests/master_replication-itest.cc
M src/kudu/master/master-test.cc
3 files changed, 101 insertions(+), 23 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/8979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8f5bbb581abeb3a781b522dff90711b2ffc988df
Gerrit-Change-Number: 8979
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [tests] update tests for replication scheme consistency
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8979 )
Change subject: [tests] update tests for replication scheme consistency
......................................................................
Patch Set 2: Verified+1
Will fix RaftConsensusITest.Test_KUDU_1735 in a separate changelist.
--
To view, visit http://gerrit.cloudera.org:8080/8979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f5bbb581abeb3a781b522dff90711b2ffc988df
Gerrit-Change-Number: 8979
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Jan 2018 21:17:22 +0000
Gerrit-HasComments: No
[kudu-CR] [tests] update tests for replication scheme consistency
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/8979 )
Change subject: [tests] update tests for replication scheme consistency
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/8979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I8f5bbb581abeb3a781b522dff90711b2ffc988df
Gerrit-Change-Number: 8979
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [tests] update tests for replication scheme consistency
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8979 )
Change subject: [tests] update tests for replication scheme consistency
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f5bbb581abeb3a781b522dff90711b2ffc988df
Gerrit-Change-Number: 8979
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 09 Jan 2018 20:28:58 +0000
Gerrit-HasComments: No
[kudu-CR] [tests] update tests for replication scheme consistency
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/8979 )
Change subject: [tests] update tests for replication scheme consistency
......................................................................
Patch Set 1: Code-Review+2
What about the raft_consensus-itest failure? Is that unrelated? I saw it locally, and it also cropped up in our nightly tests.
Here's the output from my local run: https://gist.github.com/adembo/3b28823884b457f0c4019e9e17a0ab6a.
--
To view, visit http://gerrit.cloudera.org:8080/8979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f5bbb581abeb3a781b522dff90711b2ffc988df
Gerrit-Change-Number: 8979
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 09 Jan 2018 20:22:58 +0000
Gerrit-HasComments: No
[kudu-CR] [tests] update tests for replication scheme consistency
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/8979 )
Change subject: [tests] update tests for replication scheme consistency
......................................................................
Patch Set 1:
> What about the raft_consensus-itest failure? Is that unrelated? I
> saw it locally, and it also cropped up in our nightly tests.
>
> Here's the output from my local run: https://gist.github.com/adembo/3b28823884b457f0c4019e9e17a0ab6a.
So far I could not attribute the failure in raft_consensus-itest (Test_KUDU_1735) to this stuff. But yes -- I see it fails and I'll fix it. Probably, I will add a separate changelist for that test.
--
To view, visit http://gerrit.cloudera.org:8080/8979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f5bbb581abeb3a781b522dff90711b2ffc988df
Gerrit-Change-Number: 8979
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 09 Jan 2018 20:30:07 +0000
Gerrit-HasComments: No
[kudu-CR] [tests] update tests for replication scheme consistency
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8979
to look at the new patch set (#2).
Change subject: [tests] update tests for replication scheme consistency
......................................................................
[tests] update tests for replication scheme consistency
Fixed and updated some scenarios once the re-replication scheme
consistency is enforced:
* MasterTest.TestRegisterAndHeartbeat scenario
* MasterReplicationTest.TestHeartbeatAcceptedByAnyMaster
* MasterCertAuthorityTest.RefuseToSignInvalidCSR
* MasterCertAuthorityTest.MasterLeaderSignsCSR
This is a follow-up for 1769eed53ee2c21a88a766cb72bf8c9ae622099d.
Change-Id: I8f5bbb581abeb3a781b522dff90711b2ffc988df
---
M src/kudu/integration-tests/master_cert_authority-itest.cc
M src/kudu/integration-tests/master_replication-itest.cc
M src/kudu/master/master-test.cc
3 files changed, 101 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/79/8979/2
--
To view, visit http://gerrit.cloudera.org:8080/8979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8f5bbb581abeb3a781b522dff90711b2ffc988df
Gerrit-Change-Number: 8979
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins