You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by "Kaxil Naik (JIRA)" <ji...@apache.org> on 2018/05/18 18:51:00 UTC

[jira] [Commented] (AIRFLOW-2483) Comparison with none performed with equality operators

    [ https://issues.apache.org/jira/browse/AIRFLOW-2483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16481047#comment-16481047 ] 

Kaxil Naik commented on AIRFLOW-2483:
-------------------------------------

Close this as after closer inspection the code was using String comparisons hence `==` makes sense

> Comparison with none performed with equality operators
> ------------------------------------------------------
>
>                 Key: AIRFLOW-2483
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-2483
>             Project: Apache Airflow
>          Issue Type: Improvement
>    Affects Versions: 1.9.0
>            Reporter: Kaxil Naik
>            Assignee: Kaxil Naik
>            Priority: Minor
>
> Comparison with None performed with equality operators.
> PEP 8 explicitly states that "comparisons to singletons like None should always be done with is or is not, never the equality operators."



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)