[GitHub] [tvm] shingjan commented on a diff in pull request #11074: [MetaSchedule] Reduce Local Builder Memory Usage

[GitBox <gi...@apache.org>]

shingjan commented on code in PR #11074:
URL: https://github.com/apache/tvm/pull/11074#discussion_r854697996


##########
python/tvm/meta_schedule/builder/local_builder.py:
##########
@@ -149,8 +146,14 @@ def build(self, build_inputs: List[BuilderInput]) -> List[BuilderResult]:
         results: List[BuilderResult] = []
         map_result: MapResult
 
+        pool = PopenPoolExecutor(

Review Comment:
   can we add some comment here just to show why we use `PopenPool` here differently than how we use it in RPCRunner and LocalRunner?



##########
python/tvm/meta_schedule/builder/local_builder.py:
##########
@@ -181,15 +184,22 @@ def build(self, build_inputs: List[BuilderInput]) -> List[BuilderResult]:
                 )
             else:
                 raise ValueError("Unreachable: unexpected result: {map_result}")
+        del pool
         return results
 
     def _sanity_check(self) -> None:
         def _check(f_build, f_export) -> None:
             get_global_func_with_default_on_worker(name=f_build, default=None)
             get_global_func_with_default_on_worker(name=f_export, default=None)
 
-        value = self.pool.submit(_check, self.f_build, self.f_export)
+        pool = PopenPoolExecutor(

Review Comment:
   same above



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org