[GitHub] [airflow] ashb commented on a change in pull request #15448: Add quoteChar property in the Hive table creation hql

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #15448:
URL: https://github.com/apache/airflow/pull/15448#discussion_r649305935



##########
File path: airflow/providers/apache/hive/hooks/hive.py
##########
@@ -377,11 +377,13 @@ def _infer_field_types_from_df(df: pandas.DataFrame) -> Dict[Any, Any]:
                     filepath=f.name, table=table, delimiter=delimiter, field_dict=field_dict, **kwargs
                 )
 
+    # pylint: disable=too-many-arguments
     def load_file(
         self,
         filepath: str,
         table: str,
         delimiter: str = ",",
+        quotechar: str = '\\"',

Review comment:
       This should just be
   
   ```suggestion
           quotechar: str = '"',
   ```
   
   and then any escaping necessary should be handled in the SQL generation.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org