You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by df...@apache.org on 2009/11/06 16:00:44 UTC

svn commit: r833427 - /maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/project/ProjectSorter.java

Author: dfabulich
Date: Fri Nov  6 15:00:44 2009
New Revision: 833427

URL: http://svn.apache.org/viewvc?rev=833427&view=rev
Log:
Expose the DAG and project map for reactor plugin

Modified:
    maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/project/ProjectSorter.java

Modified: maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/project/ProjectSorter.java
URL: http://svn.apache.org/viewvc/maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/project/ProjectSorter.java?rev=833427&r1=833426&r2=833427&view=diff
==============================================================================
--- maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/project/ProjectSorter.java (original)
+++ maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/project/ProjectSorter.java Fri Nov  6 15:00:44 2009
@@ -42,6 +42,8 @@
     private DAG dag;
 
     private List<MavenProject> sortedProjects;
+    
+    private Map<String, MavenProject> projectMap;
 
     private MavenProject topLevelProject;
 
@@ -74,7 +76,7 @@
         dag = new DAG();
 
         // groupId:artifactId:version -> project
-        Map<String, MavenProject> projectMap = new HashMap<String, MavenProject>( projects.size() * 2 );
+        projectMap = new HashMap<String, MavenProject>( projects.size() * 2 );
 
         // groupId:artifactId -> (version -> vertex)
         Map<String, Map<String, Vertex>> vertexMap = new HashMap<String, Map<String, Vertex>>( projects.size() * 2 );
@@ -271,5 +273,15 @@
     {
         return ArtifactUtils.key( project.getGroupId(), project.getArtifactId(), project.getVersion() );
     }
-
+    
+    public DAG getDAG()
+    {
+        return dag;
+    }
+    
+    public Map<String, MavenProject> getProjectMap()
+    {
+        return projectMap;
+    }
+    
 }



Re: svn commit: r833427 - /maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/project/Pro jectSorter.java

Posted by Dan Fabulich <da...@fabulich.com>.
Jason van Zyl wrote:

> You know that the reactor behaviour is present in in 3.x already?

I did know this; it's sweet.

There's just one maven-reactor-plugin feature missing from core, which IMO 
should NOT land in core.

It's reactor:make-scm-changes, which rebuilds all/only those projects that 
you have changed.  It relies on maven-scm to figure this out, so it's not 
a good candidate for core.  But I do need access to the DAG to get this 
information for my plugin...

-Dan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: svn commit: r833427 - /maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/project/ProjectSorter.java

Posted by Jason van Zyl <ja...@maven.org>.
On 2009-11-06, at 4:00 PM, dfabulich@apache.org wrote:

> Author: dfabulich
> Date: Fri Nov  6 15:00:44 2009
> New Revision: 833427
>
> URL: http://svn.apache.org/viewvc?rev=833427&view=rev
> Log:
> Expose the DAG and project map for reactor plugin
>

You know that the reactor behaviour is present in in 3.x already?

> Modified:
>    maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/ 
> project/ProjectSorter.java
>
> Modified: maven/maven-3/trunk/maven-core/src/main/java/org/apache/ 
> maven/project/ProjectSorter.java
> URL: http://svn.apache.org/viewvc/maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/project/ProjectSorter.java?rev=833427&r1=833426&r2=833427&view=diff
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
> --- maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/ 
> project/ProjectSorter.java (original)
> +++ maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/ 
> project/ProjectSorter.java Fri Nov  6 15:00:44 2009
> @@ -42,6 +42,8 @@
>     private DAG dag;
>
>     private List<MavenProject> sortedProjects;
> +
> +    private Map<String, MavenProject> projectMap;
>
>     private MavenProject topLevelProject;
>
> @@ -74,7 +76,7 @@
>         dag = new DAG();
>
>         // groupId:artifactId:version -> project
> -        Map<String, MavenProject> projectMap = new HashMap<String,  
> MavenProject>( projects.size() * 2 );
> +        projectMap = new HashMap<String, MavenProject> 
> ( projects.size() * 2 );
>
>         // groupId:artifactId -> (version -> vertex)
>         Map<String, Map<String, Vertex>> vertexMap = new  
> HashMap<String, Map<String, Vertex>>( projects.size() * 2 );
> @@ -271,5 +273,15 @@
>     {
>         return ArtifactUtils.key( project.getGroupId(),  
> project.getArtifactId(), project.getVersion() );
>     }
> -
> +
> +    public DAG getDAG()
> +    {
> +        return dag;
> +    }
> +
> +    public Map<String, MavenProject> getProjectMap()
> +    {
> +        return projectMap;
> +    }
> +
> }
>
>

Thanks,

Jason

----------------------------------------------------------
Jason van Zyl
Founder,  Apache Maven
http://twitter.com/jvanzyl
----------------------------------------------------------


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org