You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by unsleepy22 <gi...@git.apache.org> on 2016/03/09 09:08:18 UTC
[GitHub] storm pull request: [STORM-1605] use '/usr/bin/env python' to chec...
GitHub user unsleepy22 opened a pull request:
https://github.com/apache/storm/pull/1196
[STORM-1605] use '/usr/bin/env python' to check python version
Current python version check is hard-coded and it cannot detect python 2.7.x versions. Changed to /usr/bin/env to keep consistent with storm.py
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/unsleepy22/storm STORM-1605
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1196.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1196
----
commit 20f1497c213c97a8a72b2f43039ad59ce9ce5169
Author: 卫乐 <we...@taobao.com>
Date: 2016-03-09T08:05:04Z
use '/usr/bin/env python' to check python version
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1605] use '/usr/bin/env python' to chec...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/1196#issuecomment-195848826
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1605] use '/usr/bin/env python' to chec...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1196
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1605] use '/usr/bin/env python' to chec...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1196#issuecomment-194870129
+1 looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1605] use '/usr/bin/env python' to chec...
Posted by hustfxj <gi...@git.apache.org>.
Github user hustfxj commented on the pull request:
https://github.com/apache/storm/pull/1196#issuecomment-194607393
@unsleepy22 It loos good to me. Many *.py files start with "#!/usr/bin/python" in storm . So do you think we should update them together or not?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1605] use '/usr/bin/env python' to chec...
Posted by unsleepy22 <gi...@git.apache.org>.
Github user unsleepy22 commented on the pull request:
https://github.com/apache/storm/pull/1196#issuecomment-194628221
@hustfxj thanks for pointing out, I added storm.py too. But for the other files, I prefer to leave them alone since they're not part of storm-core.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---