You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/10/03 06:38:46 UTC

[GitHub] [apisix] leslie-tsang opened a new pull request #5169: chore: keep same return behavior in upstream.lua

leslie-tsang opened a new pull request #5169:
URL: https://github.com/apache/apisix/pull/5169


   var `HTTP_CODE_UPSTREAM_UNAVAILABLE` cause different return value behavior.
   
   Signed-off-by: leslie tsang <le...@icloud.com>
   
   ### What this PR does / why we need it:
   <!--- Why is this change required? What problem does it solve? -->
   <!--- If it fixes an open issue, please link to the issue here. -->
   
   ### Pre-submission checklist:
   
   * [x] Did you explain what problem does this PR solve? Or what new features have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] spacewander commented on pull request #5169: chore: keep same return behavior in upstream.lua

Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #5169:
URL: https://github.com/apache/apisix/pull/5169#issuecomment-932933955


   Better avoid submitting such meaningless chore PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] spacewander closed pull request #5169: chore: keep same return behavior in upstream.lua

Posted by GitBox <gi...@apache.org>.
spacewander closed pull request #5169:
URL: https://github.com/apache/apisix/pull/5169


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] spacewander commented on pull request #5169: chore: keep same return behavior in upstream.lua

Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #5169:
URL: https://github.com/apache/apisix/pull/5169#issuecomment-932936105


   Of course, this PR is not spam. But such PR doesn't bring any meaning to an open source project and just wastes the limited time of the maintainer.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org