[GitHub] [hudi] danny0405 commented on a diff in pull request #7410: [HUDI-3478] imporve cdc-related codes

["danny0405 (via GitHub)" <gi...@apache.org>]

danny0405 commented on code in PR #7410:
URL: https://github.com/apache/hudi/pull/7410#discussion_r1089610089


##########
hudi-common/src/main/java/org/apache/hudi/common/table/cdc/HoodieCDCExtractor.java:
##########
@@ -267,7 +267,7 @@ private HoodieCDCFileSplit parseWriteStat(
           FileSlice beforeFileSlice = new FileSlice(fileGroupId, writeStat.getPrevCommit(), beforeBaseFile, Collections.emptyList());
           cdcFileSplit = new HoodieCDCFileSplit(instantTs, BASE_FILE_DELETE, new ArrayList<>(), Option.empty(), Option.of(beforeFileSlice));
         } else if (writeStat.getNumUpdateWrites() == 0L && writeStat.getNumDeletes() == 0
-            && writeStat.getNumWrites() == writeStat.getNumInserts()) {
+            && writeStat.getNumWrites() > 0) {

Review Comment:
   How about rename `HoodieCDCInferenceCase` into `HoodieChangelogType`, I'm confused by what `Inference Case` really means.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org