You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by vesense <gi...@git.apache.org> on 2016/01/16 07:07:36 UTC
[GitHub] storm pull request: [STORM-1479] use a simple implemention for Int...
GitHub user vesense opened a pull request:
https://github.com/apache/storm/pull/1021
[STORM-1479] use a simple implemention for IntSerializer
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vesense/storm STORM-1479
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1021.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1021
----
commit f7d59601ae54128ab9effa1baa8933d81b7e317b
Author: Xin Wang <be...@163.com>
Date: 2016-01-16T06:06:45Z
simple implemention for integer ser
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1479] use a simple implemention for Int...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1021
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1479] use a simple implemention for Int...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1021#issuecomment-174003350
+1 looks OK to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1479] use a simple implemention for Int...
Posted by arunmahadevan <gi...@git.apache.org>.
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1021#issuecomment-172212641
MulitScheme implementations appear to deserialize raw bytes or String, not Integer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1479] use a simple implemention for Int...
Posted by arunmahadevan <gi...@git.apache.org>.
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1021#issuecomment-172169957
Changes looks good. But wonder why isn't there a corresponding IntDeserializer?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1479] use a simple implemention for Int...
Posted by vesense <gi...@git.apache.org>.
Github user vesense commented on the pull request:
https://github.com/apache/storm/pull/1021#issuecomment-172182776
@arunmahadevan
This class is used by StormSQL.
>In StormSQL data is represented by external tables. Users can specify data sources using the CREATE EXTERNAL TABLE statement.
* kafka as data source
use XXXSerializer for data ser.
* kafka as data sink
use `org/apache/storm/spout/MultiScheme.java` for data deser.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---