You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/11/14 14:19:23 UTC

[GitHub] [incubator-kyuubi] zhenjiaguo commented on pull request #1378: [KYUUBI #1050] Add KyuubiServerStartEvent

zhenjiaguo commented on pull request #1378:
URL: https://github.com/apache/incubator-kyuubi/pull/1378#issuecomment-968299588


   @ulysses-you  Sorry, I didn't see you are sending a PR. I didn't search [Pull requests](https://github.com/apache/incubator-kyuubi/pulls) before I do this work. 
   
   After watching your [PR](https://github.com/apache/incubator-kyuubi/pull/1051), I realized we need to collect more info and need to send an event when kyuubi server stop. I will do it later.
   
   It may not a good idea to change trait KyuubiServerEvent to ServerEvent. So I have a question, what name of the event when kyuubi server start and stop to send is suitable? How about KyuubiServerInfoEvent or KyuubiServerSystemEvent?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org