You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flink.apache.org by Dong Lin <li...@gmail.com> on 2023/02/13 03:03:25 UTC
[VOTE] FLIP-289: Support online inference (Flink ML)
Hi all,
We would like to start the vote for FLIP-289: Support online inference
(Flink ML) [1]. This FLIP was discussed in this thread [2].
The goal of this FLIP is to enable users to use the model trained by Flink
ML to do online inference.
The vote will be open until at least Feb 16th (at least 72 hours), following
the consensus voting process.
Thanks!
Dong
[1]
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=240881268
[2] https://lists.apache.org/thread/m006xymqto1kp0s80sr8jqbbmw6fq9sg
Re: [VOTE] FLIP-289: Support online inference (Flink ML)
Posted by Dian Fu <di...@gmail.com>.
Hi Dong,
Thanks for the explanation. The changes sound reasonable to me. It could
avoid changing the interface again in the future and so +1 from my side.
Regards,
Dian
On Fri, Feb 24, 2023 at 2:03 PM Zhipeng Zhang <zh...@gmail.com>
wrote:
> Thanks for the update. The change looks good to me.
>
> So +1 from my side.
>
> Dong Lin <li...@gmail.com> 于2023年2月24日周五 13:56写道：
> >
> > As we are working on FLIP-289 PR, we realized that we need to make
> > one minor change to the ModelServable#setModelData() API.
> >
> > More specifically, we would like to update the ModelServable#setModelData
> > to use the following signature. It additionally throws IOException and
> > allows users to provide multiple input streams.
> >
> > *default T setModelData(InputStream... modelData) throws IOException*
> >
> > The reason for having this method takes multiple input streams is that in
> > the future we might want to package multiple servables into one servable
> > (similar to what we can do with the existing GraphModel). This means that
> > the packaging servable needs to be able to take multiple model data
> streams
> > and pass them to the underlying servables.
> >
> > Since this change is relatively minor and looks good to me, I will re-use
> > this voting thread to confirm whether this change is OK.
> >
> > Dian and Zhipeng: can you help check whether this public interface change
> > looks good to you?
> >
> > I will keep this discussion open for at least 72 hours before merging the
> > PR.
> >
> > Thanks,
> > Dong
> >
> >
> > On Thu, Feb 16, 2023 at 9:42 PM Dong Lin <li...@gmail.com> wrote:
> >
> > > Thank you all for the votes!
> > >
> > > The vote is now closed. I will announce the results in a separate
> email.
> > >
> > > Cheers,
> > > Dong
> > >
> > > On Thu, Feb 16, 2023 at 6:02 PM Zhipeng Zhang <zhangzhipengw@gmail.com
> >
> > > wrote:
> > >
> > >> +1 (binding)
> > >>
> > >> Regards,
> > >> Zhipeng
> > >>
> > >> Dian Fu <di...@gmail.com> 于2023年2月13日周一 20:21写道：
> > >> >
> > >> > +1 (binding)
> > >> >
> > >> > Regards,
> > >> > Dian
> > >> >
> > >> > On Mon, Feb 13, 2023 at 11:04 AM Dong Lin <li...@gmail.com>
> wrote:
> > >> >
> > >> > > Hi all,
> > >> > >
> > >> > > We would like to start the vote for FLIP-289: Support online
> inference
> > >> > > (Flink ML) [1]. This FLIP was discussed in this thread [2].
> > >> > >
> > >> > > The goal of this FLIP is to enable users to use the model trained
> by
> > >> Flink
> > >> > > ML to do online inference.
> > >> > >
> > >> > > The vote will be open until at least Feb 16th (at least 72 hours),
> > >> > > following
> > >> > > the consensus voting process.
> > >> > >
> > >> > > Thanks!
> > >> > > Dong
> > >> > >
> > >> > > [1]
> > >> > >
> > >>
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=240881268
> > >> > > [2]
> https://lists.apache.org/thread/m006xymqto1kp0s80sr8jqbbmw6fq9sg
> > >> > >
> > >>
> > >>
> > >>
> > >> --
> > >> best,
> > >> Zhipeng
> > >>
> > >
>
>
>
> --
> best,
> Zhipeng
>
Re: [VOTE] FLIP-289: Support online inference (Flink ML)
Posted by Zhipeng Zhang <zh...@gmail.com>.
Thanks for the update. The change looks good to me.
So +1 from my side.
Dong Lin <li...@gmail.com> 于2023年2月24日周五 13:56写道：
>
> As we are working on FLIP-289 PR, we realized that we need to make
> one minor change to the ModelServable#setModelData() API.
>
> More specifically, we would like to update the ModelServable#setModelData
> to use the following signature. It additionally throws IOException and
> allows users to provide multiple input streams.
>
> *default T setModelData(InputStream... modelData) throws IOException*
>
> The reason for having this method takes multiple input streams is that in
> the future we might want to package multiple servables into one servable
> (similar to what we can do with the existing GraphModel). This means that
> the packaging servable needs to be able to take multiple model data streams
> and pass them to the underlying servables.
>
> Since this change is relatively minor and looks good to me, I will re-use
> this voting thread to confirm whether this change is OK.
>
> Dian and Zhipeng: can you help check whether this public interface change
> looks good to you?
>
> I will keep this discussion open for at least 72 hours before merging the
> PR.
>
> Thanks,
> Dong
>
>
> On Thu, Feb 16, 2023 at 9:42 PM Dong Lin <li...@gmail.com> wrote:
>
> > Thank you all for the votes!
> >
> > The vote is now closed. I will announce the results in a separate email.
> >
> > Cheers,
> > Dong
> >
> > On Thu, Feb 16, 2023 at 6:02 PM Zhipeng Zhang <zh...@gmail.com>
> > wrote:
> >
> >> +1 (binding)
> >>
> >> Regards,
> >> Zhipeng
> >>
> >> Dian Fu <di...@gmail.com> 于2023年2月13日周一 20:21写道：
> >> >
> >> > +1 (binding)
> >> >
> >> > Regards,
> >> > Dian
> >> >
> >> > On Mon, Feb 13, 2023 at 11:04 AM Dong Lin <li...@gmail.com> wrote:
> >> >
> >> > > Hi all,
> >> > >
> >> > > We would like to start the vote for FLIP-289: Support online inference
> >> > > (Flink ML) [1]. This FLIP was discussed in this thread [2].
> >> > >
> >> > > The goal of this FLIP is to enable users to use the model trained by
> >> Flink
> >> > > ML to do online inference.
> >> > >
> >> > > The vote will be open until at least Feb 16th (at least 72 hours),
> >> > > following
> >> > > the consensus voting process.
> >> > >
> >> > > Thanks!
> >> > > Dong
> >> > >
> >> > > [1]
> >> > >
> >> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=240881268
> >> > > [2] https://lists.apache.org/thread/m006xymqto1kp0s80sr8jqbbmw6fq9sg
> >> > >
> >>
> >>
> >>
> >> --
> >> best,
> >> Zhipeng
> >>
> >
--
best,
Zhipeng
Re: [VOTE] FLIP-289: Support online inference (Flink ML)
Posted by Dong Lin <li...@gmail.com>.
As we are working on FLIP-289 PR, we realized that we need to make
one minor change to the ModelServable#setModelData() API.
More specifically, we would like to update the ModelServable#setModelData
to use the following signature. It additionally throws IOException and
allows users to provide multiple input streams.
*default T setModelData(InputStream... modelData) throws IOException*
The reason for having this method takes multiple input streams is that in
the future we might want to package multiple servables into one servable
(similar to what we can do with the existing GraphModel). This means that
the packaging servable needs to be able to take multiple model data streams
and pass them to the underlying servables.
Since this change is relatively minor and looks good to me, I will re-use
this voting thread to confirm whether this change is OK.
Dian and Zhipeng: can you help check whether this public interface change
looks good to you?
I will keep this discussion open for at least 72 hours before merging the
PR.
Thanks,
Dong
On Thu, Feb 16, 2023 at 9:42 PM Dong Lin <li...@gmail.com> wrote:
> Thank you all for the votes!
>
> The vote is now closed. I will announce the results in a separate email.
>
> Cheers,
> Dong
>
> On Thu, Feb 16, 2023 at 6:02 PM Zhipeng Zhang <zh...@gmail.com>
> wrote:
>
>> +1 (binding)
>>
>> Regards,
>> Zhipeng
>>
>> Dian Fu <di...@gmail.com> 于2023年2月13日周一 20:21写道：
>> >
>> > +1 (binding)
>> >
>> > Regards,
>> > Dian
>> >
>> > On Mon, Feb 13, 2023 at 11:04 AM Dong Lin <li...@gmail.com> wrote:
>> >
>> > > Hi all,
>> > >
>> > > We would like to start the vote for FLIP-289: Support online inference
>> > > (Flink ML) [1]. This FLIP was discussed in this thread [2].
>> > >
>> > > The goal of this FLIP is to enable users to use the model trained by
>> Flink
>> > > ML to do online inference.
>> > >
>> > > The vote will be open until at least Feb 16th (at least 72 hours),
>> > > following
>> > > the consensus voting process.
>> > >
>> > > Thanks!
>> > > Dong
>> > >
>> > > [1]
>> > >
>> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=240881268
>> > > [2] https://lists.apache.org/thread/m006xymqto1kp0s80sr8jqbbmw6fq9sg
>> > >
>>
>>
>>
>> --
>> best,
>> Zhipeng
>>
>
Re: [VOTE] FLIP-289: Support online inference (Flink ML)
Posted by Dong Lin <li...@gmail.com>.
Thank you all for the votes!
The vote is now closed. I will announce the results in a separate email.
Cheers,
Dong
On Thu, Feb 16, 2023 at 6:02 PM Zhipeng Zhang <zh...@gmail.com>
wrote:
> +1 (binding)
>
> Regards,
> Zhipeng
>
> Dian Fu <di...@gmail.com> 于2023年2月13日周一 20:21写道：
> >
> > +1 (binding)
> >
> > Regards,
> > Dian
> >
> > On Mon, Feb 13, 2023 at 11:04 AM Dong Lin <li...@gmail.com> wrote:
> >
> > > Hi all,
> > >
> > > We would like to start the vote for FLIP-289: Support online inference
> > > (Flink ML) [1]. This FLIP was discussed in this thread [2].
> > >
> > > The goal of this FLIP is to enable users to use the model trained by
> Flink
> > > ML to do online inference.
> > >
> > > The vote will be open until at least Feb 16th (at least 72 hours),
> > > following
> > > the consensus voting process.
> > >
> > > Thanks!
> > > Dong
> > >
> > > [1]
> > >
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=240881268
> > > [2] https://lists.apache.org/thread/m006xymqto1kp0s80sr8jqbbmw6fq9sg
> > >
>
>
>
> --
> best,
> Zhipeng
>
Re: [VOTE] FLIP-289: Support online inference (Flink ML)
Posted by Zhipeng Zhang <zh...@gmail.com>.
+1 (binding)
Regards,
Zhipeng
Dian Fu <di...@gmail.com> 于2023年2月13日周一 20:21写道：
>
> +1 (binding)
>
> Regards,
> Dian
>
> On Mon, Feb 13, 2023 at 11:04 AM Dong Lin <li...@gmail.com> wrote:
>
> > Hi all,
> >
> > We would like to start the vote for FLIP-289: Support online inference
> > (Flink ML) [1]. This FLIP was discussed in this thread [2].
> >
> > The goal of this FLIP is to enable users to use the model trained by Flink
> > ML to do online inference.
> >
> > The vote will be open until at least Feb 16th (at least 72 hours),
> > following
> > the consensus voting process.
> >
> > Thanks!
> > Dong
> >
> > [1]
> > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=240881268
> > [2] https://lists.apache.org/thread/m006xymqto1kp0s80sr8jqbbmw6fq9sg
> >
--
best,
Zhipeng
Re: [VOTE] FLIP-289: Support online inference (Flink ML)
Posted by Dian Fu <di...@gmail.com>.
+1 (binding)
Regards,
Dian
On Mon, Feb 13, 2023 at 11:04 AM Dong Lin <li...@gmail.com> wrote:
> Hi all,
>
> We would like to start the vote for FLIP-289: Support online inference
> (Flink ML) [1]. This FLIP was discussed in this thread [2].
>
> The goal of this FLIP is to enable users to use the model trained by Flink
> ML to do online inference.
>
> The vote will be open until at least Feb 16th (at least 72 hours),
> following
> the consensus voting process.
>
> Thanks!
> Dong
>
> [1]
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=240881268
> [2] https://lists.apache.org/thread/m006xymqto1kp0s80sr8jqbbmw6fq9sg
>