You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by cr...@locus.apache.org on 2000/06/27 04:48:07 UTC
cvs commit: jakarta-struts/src/share/org/apache/struts/taglib BaseInputTag.java
craigmcc 00/06/26 19:48:07
Modified: src/share/org/apache/struts/taglib BaseInputTag.java
Log:
Remove all the cases I can remember where two setters (one for int and one
for String) are provided, per the clarification to the JSP 1.1 specs.
Why did I delete the "int" versions of the setters? Good question -- the
answer is that keeping the "int" setters and deleting the "String" setters
does not work on Tomcat -- an issue I'm going to address separately,
because they should.
In the mean time, this fix should solve issues on Orion where the server
complained about "size" being a read-only property. Could those who have
experienced this error please download the new version and confirm that it
has been fixed?
Revision Changes Path
1.4 +4 -52 jakarta-struts/src/share/org/apache/struts/taglib/BaseInputTag.java
Index: BaseInputTag.java
===================================================================
RCS file: /home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/BaseInputTag.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- BaseInputTag.java 2000/06/16 04:41:07 1.3
+++ BaseInputTag.java 2000/06/27 02:48:07 1.4
@@ -1,7 +1,7 @@
/*
- * $Header: /home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/BaseInputTag.java,v 1.3 2000/06/16 04:41:07 craigmcc Exp $
- * $Revision: 1.3 $
- * $Date: 2000/06/16 04:41:07 $
+ * $Header: /home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/BaseInputTag.java,v 1.4 2000/06/27 02:48:07 craigmcc Exp $
+ * $Revision: 1.4 $
+ * $Date: 2000/06/27 02:48:07 $
*
* ====================================================================
*
@@ -74,7 +74,7 @@
* Abstract base class for the various input tags.
*
* @author Craig R. McClanahan
- * @version $Revision: 1.3 $ $Date: 2000/06/16 04:41:07 $
+ * @version $Revision: 1.4 $ $Date: 2000/06/27 02:48:07 $
*/
public abstract class BaseInputTag extends BaseHandlerTag {
@@ -141,18 +141,6 @@
*
* @param cols The new number of columns
*/
- public void setCols(int cols) {
-
- this.cols = cols;
-
- }
-
-
- /**
- * Set the number of columns for this field.
- *
- * @param cols The new number of columns
- */
public void setCols(String cols) {
try {
@@ -179,18 +167,6 @@
*
* @param maxlength The new maximum length
*/
- public void setMaxlength(int maxlength) {
-
- this.maxlength = maxlength;
-
- }
-
-
- /**
- * Set the maximum length allowed.
- *
- * @param maxlength The new maximum length
- */
public void setMaxlength(String maxlength) {
try {
@@ -239,18 +215,6 @@
*
* @param rows The new number of rows
*/
- public void setRows(int rows) {
-
- this.rows = rows;
-
- }
-
-
- /**
- * Set the number of rows for this field.
- *
- * @param rows The new number of rows
- */
public void setRows(String rows) {
try {
@@ -268,18 +232,6 @@
public int getSize() {
return (getCols());
-
- }
-
-
- /**
- * Set the size of this field (synonym for <code>setCols()</code>).
- *
- * @param size The new size
- */
- public void setSize(int size) {
-
- setCols(size);
}