[Impala-ASF-CR] IMPALA-12433: Share buffers among channels in KrpcDataStreamSender

["Zihao Ye (Code Review)" <ge...@cloudera.org>]

Zihao Ye has posted comments on this change. ( http://gerrit.cloudera.org:8080/20719 )

Change subject: IMPALA-12433: Share buffers among channels in KrpcDataStreamSender
......................................................................


Patch Set 12: Code-Review+1

(2 comments)

Looks great!

http://gerrit.cloudera.org:8080/#/c/20719/12/be/src/runtime/krpc-data-stream-sender.cc
File be/src/runtime/krpc-data-stream-sender.cc:

http://gerrit.cloudera.org:8080/#/c/20719/12/be/src/runtime/krpc-data-stream-sender.cc@1056
PS12, Line 1056:  
nit: redundant space


http://gerrit.cloudera.org:8080/#/c/20719/12/be/src/runtime/row-batch.cc
File be/src/runtime/row-batch.cc:

http://gerrit.cloudera.org:8080/#/c/20719/12/be/src/runtime/row-batch.cc@280
PS12, Line 280: _
nit: redundant underline



-- 
To view, visit http://gerrit.cloudera.org:8080/20719
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I64854a350a9dae8bf3af11c871882ea4750e60b3
Gerrit-Change-Number: 20719
Gerrit-PatchSet: 12
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Fri, 02 Feb 2024 07:02:06 +0000
Gerrit-HasComments: Yes