You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuweni.apache.org by Antoine Toulme <an...@toulme.name> on 2020/05/30 06:22:03 UTC
Fwd: [RESULT][VOTE] Apache Tuweni 1.1.0 release
> Begin forwarded message:
>
> From: Antoine Toulme <an...@toulme.name>
> Subject: [RESULT][VOTE] Apache Tuweni 1.1.0 release
> Date: May 29, 2020 at 11:21:47 PM PDT
> To: general@incubator.apache.org
>
> The result of the vote is as follows:
> 1 +1: Furkan Kamaci
> 0 +0:
> 1 -1: Justin Mclean
>
> The vote does not pass. We will submit a new release candidate. Thank you!
>
> Cheers,
>
> Antoine
>
>> On May 21, 2020, at 10:57 PM, Justin Mclean <ju...@classsoftware.com> wrote:
>>
>> HI,
>>
>> -1 (binding) as I cannot compile the source package from source
>>
>> I checked:
>> - incubating in name
>> - signatures and hashes are fine
>> - DISCLAIMER exits
>> - LICENSE and NOTICE
>> - No unexpected binary files
>> - All ASF files have ASF headers
>>
>> The build fails for me as it expect it to be in a git repo. You should be able to compile teh source package without access to the GitHub repo.
>>
>> Error was:
>> * What went wrong:
>> A problem occurred evaluating root project 'tuweni'.
>>> eth-reference-tests/src/test/resources/eth2.0-tests/README.md missing: please clone submodules (git submodule update --init --recursive)
>>
>> Thanks,
>> Justin
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: general-help@incubator.apache.org
>>
>
Re: [RESULT][VOTE] Apache Tuweni 1.1.0 release
Posted by Antoine Toulme <an...@toulme.name>.
First off, thanks for the help and helping move things along.
The current 1.1.0 RC is a dud. We need to:
* Close the repository under repository.apache.org <http://repository.apache.org/>
* Delete the tag in git
* Delete the staged artifacts under svn.
We can cherry-pick changes or choose to delete the 1.1 branch and take the latest from master.
There are some useful directives on how to make releases under https://github.com/apache/incubator-tuweni/blob/master/RELEASE.md <https://github.com/apache/incubator-tuweni/blob/master/RELEASE.md>
For better or worse, I’m responsible for not moving faster on this. I’ll try to pick it up tonight.
Cheers,
Antoine
> On Jun 15, 2020, at 2:23 PM, Danno Ferrin <da...@shemnon.com> wrote:
>
> Now that the source and windows fixes are merged how do we want to move
> forward with a 1.1 release? Do we cherry-pick these changes into the 1.1
> release? Do we release off of master? Is it 1.1.1 or 1.1.0?
>
> On Sat, Jun 13, 2020 at 3:56 PM Danno Ferrin <da...@shemnon.com>
> wrote:
>
>>
>>
>> On Sat, Jun 13, 2020 at 12:19 AM Antoine Toulme <an...@toulme.name>
>> wrote:
>>
>>>
>>>> On Jun 12, 2020, at 10:30 PM, Danno Ferrin <da...@shemnon.com>
>>> wrote:
>>>>
>>>> Is this from the src.zip or from a github zip?
>>>>
>>>> The tuweni-src-1.1.0-incubating.tgz won't build because of the way the
>>>> source files are arranged in the src directory. I get needing to drop
>>> the
>>>> gradlew bootstrap and test files but we also include the build.gradle at
>>>> the moment. I propose changing the layout of the src tgz to allow for
>>>> building from that.
>>> From the distributions source we produce as part of the dist module.
>>> We have had also the need to make sure sources can be built on any system
>>> out there - Windows, JDK 14, etc.
>>> So I have been building a Dockerfile for this a bit.
>>>
>>
>> Are the only two issues driving build-in-docker Windows and JDK 14? I
>> think it's better to address the root problem than paper over it.
>>
>> Regarding windows builds I think I submitted a patch a month ago to fix
>> that.
>>
>> For JDK 14 is it an issue with the outdated version of the gradle
>> wrapper? Any reason we couldn't just upgrade it to the most recent gradle
>> version?
>>
>> Any other issues driving the docker build?
>>
>>
>>>>
>>>> Regarding the reference tests I see two paths forward:
>>>> (a) Take the reference tests modules out of the codebase. None of the
>>>> tuweni projects actually use them. Anyone interested in them knows
>>> where
>>>> they reside and likely already has them as a submodule in their project
>>> We do use at least some for RLP and transactions. We use an outdated ssh
>>> repo for testing, and never had a change to make the jump.
>>> That said, I’m fine with dropping them rather than do half the job right.
>>>
>>>
>> Are you referring to the test files in the eth reference tests then?
>> There are no such files in the eth2 project. So I think if all we are
>> looking for is validation we can trim out the eth2 submodule.
>>
>>
>>>>
>>>> (b) Don't make unloaded submodules a build break. Instead perhaps a
>>> loud
>>>> warning and disabling the relevant subprojects. This also works well
>>> will
>>>> building from the .tgz since test files are not shipped and these only
>>>> exist as test files at the moment.
>>> Sounds sensible.
>>
>>>
>>>> On Sat, May 30, 2020 at 12:22 AM Antoine Toulme <an...@toulme.name>
>>> wrote:
>>>>
>>>>>
>>>>>
>>>>>> Begin forwarded message:
>>>>>>
>>>>>> From: Antoine Toulme <an...@toulme.name>
>>>>>> Subject: [RESULT][VOTE] Apache Tuweni 1.1.0 release
>>>>>> Date: May 29, 2020 at 11:21:47 PM PDT
>>>>>> To: general@incubator.apache.org
>>>>>>
>>>>>> The result of the vote is as follows:
>>>>>> 1 +1: Furkan Kamaci
>>>>>> 0 +0:
>>>>>> 1 -1: Justin Mclean
>>>>>>
>>>>>> The vote does not pass. We will submit a new release candidate. Thank
>>>>> you!
>>>>>>
>>>>>> Cheers,
>>>>>>
>>>>>> Antoine
>>>>>>
>>>>>>> On May 21, 2020, at 10:57 PM, Justin Mclean <
>>> justin@classsoftware.com>
>>>>> wrote:
>>>>>>>
>>>>>>> HI,
>>>>>>>
>>>>>>> -1 (binding) as I cannot compile the source package from source
>>>>>>>
>>>>>>> I checked:
>>>>>>> - incubating in name
>>>>>>> - signatures and hashes are fine
>>>>>>> - DISCLAIMER exits
>>>>>>> - LICENSE and NOTICE
>>>>>>> - No unexpected binary files
>>>>>>> - All ASF files have ASF headers
>>>>>>>
>>>>>>> The build fails for me as it expect it to be in a git repo. You
>>> should
>>>>> be able to compile teh source package without access to the GitHub
>>> repo.
>>>>>>>
>>>>>>> Error was:
>>>>>>> * What went wrong:
>>>>>>> A problem occurred evaluating root project 'tuweni'.
>>>>>>>> eth-reference-tests/src/test/resources/eth2.0-tests/README.md
>>> missing:
>>>>> please clone submodules (git submodule update --init --recursive)
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Justin
>>>>>>> ---------------------------------------------------------------------
>>>>>>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>>>>>>> For additional commands, e-mail: general-help@incubator.apache.org
>>>>>>>
>>>>>>
>>>>>
>>>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
>>> For additional commands, e-mail: dev-help@tuweni.apache.org
>>>
>>>
Re: [RESULT][VOTE] Apache Tuweni 1.1.0 release
Posted by Danno Ferrin <da...@shemnon.com>.
Now that the source and windows fixes are merged how do we want to move
forward with a 1.1 release? Do we cherry-pick these changes into the 1.1
release? Do we release off of master? Is it 1.1.1 or 1.1.0?
On Sat, Jun 13, 2020 at 3:56 PM Danno Ferrin <da...@shemnon.com>
wrote:
>
>
> On Sat, Jun 13, 2020 at 12:19 AM Antoine Toulme <an...@toulme.name>
> wrote:
>
>>
>> > On Jun 12, 2020, at 10:30 PM, Danno Ferrin <da...@shemnon.com>
>> wrote:
>> >
>> > Is this from the src.zip or from a github zip?
>> >
>> > The tuweni-src-1.1.0-incubating.tgz won't build because of the way the
>> > source files are arranged in the src directory. I get needing to drop
>> the
>> > gradlew bootstrap and test files but we also include the build.gradle at
>> > the moment. I propose changing the layout of the src tgz to allow for
>> > building from that.
>> From the distributions source we produce as part of the dist module.
>> We have had also the need to make sure sources can be built on any system
>> out there - Windows, JDK 14, etc.
>> So I have been building a Dockerfile for this a bit.
>>
>
> Are the only two issues driving build-in-docker Windows and JDK 14? I
> think it's better to address the root problem than paper over it.
>
> Regarding windows builds I think I submitted a patch a month ago to fix
> that.
>
> For JDK 14 is it an issue with the outdated version of the gradle
> wrapper? Any reason we couldn't just upgrade it to the most recent gradle
> version?
>
> Any other issues driving the docker build?
>
>
>> >
>> > Regarding the reference tests I see two paths forward:
>> > (a) Take the reference tests modules out of the codebase. None of the
>> > tuweni projects actually use them. Anyone interested in them knows
>> where
>> > they reside and likely already has them as a submodule in their project
>> We do use at least some for RLP and transactions. We use an outdated ssh
>> repo for testing, and never had a change to make the jump.
>> That said, I’m fine with dropping them rather than do half the job right.
>>
>>
> Are you referring to the test files in the eth reference tests then?
> There are no such files in the eth2 project. So I think if all we are
> looking for is validation we can trim out the eth2 submodule.
>
>
>> >
>> > (b) Don't make unloaded submodules a build break. Instead perhaps a
>> loud
>> > warning and disabling the relevant subprojects. This also works well
>> will
>> > building from the .tgz since test files are not shipped and these only
>> > exist as test files at the moment.
>> Sounds sensible.
>
> >
>> > On Sat, May 30, 2020 at 12:22 AM Antoine Toulme <an...@toulme.name>
>> wrote:
>> >
>> >>
>> >>
>> >>> Begin forwarded message:
>> >>>
>> >>> From: Antoine Toulme <an...@toulme.name>
>> >>> Subject: [RESULT][VOTE] Apache Tuweni 1.1.0 release
>> >>> Date: May 29, 2020 at 11:21:47 PM PDT
>> >>> To: general@incubator.apache.org
>> >>>
>> >>> The result of the vote is as follows:
>> >>> 1 +1: Furkan Kamaci
>> >>> 0 +0:
>> >>> 1 -1: Justin Mclean
>> >>>
>> >>> The vote does not pass. We will submit a new release candidate. Thank
>> >> you!
>> >>>
>> >>> Cheers,
>> >>>
>> >>> Antoine
>> >>>
>> >>>> On May 21, 2020, at 10:57 PM, Justin Mclean <
>> justin@classsoftware.com>
>> >> wrote:
>> >>>>
>> >>>> HI,
>> >>>>
>> >>>> -1 (binding) as I cannot compile the source package from source
>> >>>>
>> >>>> I checked:
>> >>>> - incubating in name
>> >>>> - signatures and hashes are fine
>> >>>> - DISCLAIMER exits
>> >>>> - LICENSE and NOTICE
>> >>>> - No unexpected binary files
>> >>>> - All ASF files have ASF headers
>> >>>>
>> >>>> The build fails for me as it expect it to be in a git repo. You
>> should
>> >> be able to compile teh source package without access to the GitHub
>> repo.
>> >>>>
>> >>>> Error was:
>> >>>> * What went wrong:
>> >>>> A problem occurred evaluating root project 'tuweni'.
>> >>>>> eth-reference-tests/src/test/resources/eth2.0-tests/README.md
>> missing:
>> >> please clone submodules (git submodule update --init --recursive)
>> >>>>
>> >>>> Thanks,
>> >>>> Justin
>> >>>> ---------------------------------------------------------------------
>> >>>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>> >>>> For additional commands, e-mail: general-help@incubator.apache.org
>> >>>>
>> >>>
>> >>
>> >>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
>> For additional commands, e-mail: dev-help@tuweni.apache.org
>>
>>
Re: [RESULT][VOTE] Apache Tuweni 1.1.0 release
Posted by Danno Ferrin <da...@shemnon.com>.
On Sat, Jun 13, 2020 at 12:19 AM Antoine Toulme <an...@toulme.name> wrote:
>
> > On Jun 12, 2020, at 10:30 PM, Danno Ferrin <da...@shemnon.com>
> wrote:
> >
> > Is this from the src.zip or from a github zip?
> >
> > The tuweni-src-1.1.0-incubating.tgz won't build because of the way the
> > source files are arranged in the src directory. I get needing to drop
> the
> > gradlew bootstrap and test files but we also include the build.gradle at
> > the moment. I propose changing the layout of the src tgz to allow for
> > building from that.
> From the distributions source we produce as part of the dist module.
> We have had also the need to make sure sources can be built on any system
> out there - Windows, JDK 14, etc.
> So I have been building a Dockerfile for this a bit.
>
Are the only two issues driving build-in-docker Windows and JDK 14? I
think it's better to address the root problem than paper over it.
Regarding windows builds I think I submitted a patch a month ago to fix
that.
For JDK 14 is it an issue with the outdated version of the gradle wrapper?
Any reason we couldn't just upgrade it to the most recent gradle version?
Any other issues driving the docker build?
> >
> > Regarding the reference tests I see two paths forward:
> > (a) Take the reference tests modules out of the codebase. None of the
> > tuweni projects actually use them. Anyone interested in them knows where
> > they reside and likely already has them as a submodule in their project
> We do use at least some for RLP and transactions. We use an outdated ssh
> repo for testing, and never had a change to make the jump.
> That said, I’m fine with dropping them rather than do half the job right.
>
>
Are you referring to the test files in the eth reference tests then? There
are no such files in the eth2 project. So I think if all we are looking
for is validation we can trim out the eth2 submodule.
> >
> > (b) Don't make unloaded submodules a build break. Instead perhaps a loud
> > warning and disabling the relevant subprojects. This also works well
> will
> > building from the .tgz since test files are not shipped and these only
> > exist as test files at the moment.
> Sounds sensible.
>
> > On Sat, May 30, 2020 at 12:22 AM Antoine Toulme <an...@toulme.name>
> wrote:
> >
> >>
> >>
> >>> Begin forwarded message:
> >>>
> >>> From: Antoine Toulme <an...@toulme.name>
> >>> Subject: [RESULT][VOTE] Apache Tuweni 1.1.0 release
> >>> Date: May 29, 2020 at 11:21:47 PM PDT
> >>> To: general@incubator.apache.org
> >>>
> >>> The result of the vote is as follows:
> >>> 1 +1: Furkan Kamaci
> >>> 0 +0:
> >>> 1 -1: Justin Mclean
> >>>
> >>> The vote does not pass. We will submit a new release candidate. Thank
> >> you!
> >>>
> >>> Cheers,
> >>>
> >>> Antoine
> >>>
> >>>> On May 21, 2020, at 10:57 PM, Justin Mclean <justin@classsoftware.com
> >
> >> wrote:
> >>>>
> >>>> HI,
> >>>>
> >>>> -1 (binding) as I cannot compile the source package from source
> >>>>
> >>>> I checked:
> >>>> - incubating in name
> >>>> - signatures and hashes are fine
> >>>> - DISCLAIMER exits
> >>>> - LICENSE and NOTICE
> >>>> - No unexpected binary files
> >>>> - All ASF files have ASF headers
> >>>>
> >>>> The build fails for me as it expect it to be in a git repo. You should
> >> be able to compile teh source package without access to the GitHub repo.
> >>>>
> >>>> Error was:
> >>>> * What went wrong:
> >>>> A problem occurred evaluating root project 'tuweni'.
> >>>>> eth-reference-tests/src/test/resources/eth2.0-tests/README.md
> missing:
> >> please clone submodules (git submodule update --init --recursive)
> >>>>
> >>>> Thanks,
> >>>> Justin
> >>>> ---------------------------------------------------------------------
> >>>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> >>>> For additional commands, e-mail: general-help@incubator.apache.org
> >>>>
> >>>
> >>
> >>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
> For additional commands, e-mail: dev-help@tuweni.apache.org
>
>
Re: [RESULT][VOTE] Apache Tuweni 1.1.0 release
Posted by Antoine Toulme <an...@toulme.name>.
> On Jun 12, 2020, at 10:30 PM, Danno Ferrin <da...@shemnon.com> wrote:
>
> Is this from the src.zip or from a github zip?
>
> The tuweni-src-1.1.0-incubating.tgz won't build because of the way the
> source files are arranged in the src directory. I get needing to drop the
> gradlew bootstrap and test files but we also include the build.gradle at
> the moment. I propose changing the layout of the src tgz to allow for
> building from that.
From the distributions source we produce as part of the dist module.
We have had also the need to make sure sources can be built on any system out there - Windows, JDK 14, etc.
So I have been building a Dockerfile for this a bit.
>
> Regarding the reference tests I see two paths forward:
> (a) Take the reference tests modules out of the codebase. None of the
> tuweni projects actually use them. Anyone interested in them knows where
> they reside and likely already has them as a submodule in their project
We do use at least some for RLP and transactions. We use an outdated ssh repo for testing, and never had a change to make the jump.
That said, I’m fine with dropping them rather than do half the job right.
>
> (b) Don't make unloaded submodules a build break. Instead perhaps a loud
> warning and disabling the relevant subprojects. This also works well will
> building from the .tgz since test files are not shipped and these only
> exist as test files at the moment.
Sounds sensible.
>
> On Sat, May 30, 2020 at 12:22 AM Antoine Toulme <an...@toulme.name> wrote:
>
>>
>>
>>> Begin forwarded message:
>>>
>>> From: Antoine Toulme <an...@toulme.name>
>>> Subject: [RESULT][VOTE] Apache Tuweni 1.1.0 release
>>> Date: May 29, 2020 at 11:21:47 PM PDT
>>> To: general@incubator.apache.org
>>>
>>> The result of the vote is as follows:
>>> 1 +1: Furkan Kamaci
>>> 0 +0:
>>> 1 -1: Justin Mclean
>>>
>>> The vote does not pass. We will submit a new release candidate. Thank
>> you!
>>>
>>> Cheers,
>>>
>>> Antoine
>>>
>>>> On May 21, 2020, at 10:57 PM, Justin Mclean <ju...@classsoftware.com>
>> wrote:
>>>>
>>>> HI,
>>>>
>>>> -1 (binding) as I cannot compile the source package from source
>>>>
>>>> I checked:
>>>> - incubating in name
>>>> - signatures and hashes are fine
>>>> - DISCLAIMER exits
>>>> - LICENSE and NOTICE
>>>> - No unexpected binary files
>>>> - All ASF files have ASF headers
>>>>
>>>> The build fails for me as it expect it to be in a git repo. You should
>> be able to compile teh source package without access to the GitHub repo.
>>>>
>>>> Error was:
>>>> * What went wrong:
>>>> A problem occurred evaluating root project 'tuweni'.
>>>>> eth-reference-tests/src/test/resources/eth2.0-tests/README.md missing:
>> please clone submodules (git submodule update --init --recursive)
>>>>
>>>> Thanks,
>>>> Justin
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>>>> For additional commands, e-mail: general-help@incubator.apache.org
>>>>
>>>
>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
Re: [RESULT][VOTE] Apache Tuweni 1.1.0 release
Posted by Danno Ferrin <da...@shemnon.com>.
Is this from the src.zip or from a github zip?
The tuweni-src-1.1.0-incubating.tgz won't build because of the way the
source files are arranged in the src directory. I get needing to drop the
gradlew bootstrap and test files but we also include the build.gradle at
the moment. I propose changing the layout of the src tgz to allow for
building from that.
Regarding the reference tests I see two paths forward:
(a) Take the reference tests modules out of the codebase. None of the
tuweni projects actually use them. Anyone interested in them knows where
they reside and likely already has them as a submodule in their project
(b) Don't make unloaded submodules a build break. Instead perhaps a loud
warning and disabling the relevant subprojects. This also works well will
building from the .tgz since test files are not shipped and these only
exist as test files at the moment.
On Sat, May 30, 2020 at 12:22 AM Antoine Toulme <an...@toulme.name> wrote:
>
>
> > Begin forwarded message:
> >
> > From: Antoine Toulme <an...@toulme.name>
> > Subject: [RESULT][VOTE] Apache Tuweni 1.1.0 release
> > Date: May 29, 2020 at 11:21:47 PM PDT
> > To: general@incubator.apache.org
> >
> > The result of the vote is as follows:
> > 1 +1: Furkan Kamaci
> > 0 +0:
> > 1 -1: Justin Mclean
> >
> > The vote does not pass. We will submit a new release candidate. Thank
> you!
> >
> > Cheers,
> >
> > Antoine
> >
> >> On May 21, 2020, at 10:57 PM, Justin Mclean <ju...@classsoftware.com>
> wrote:
> >>
> >> HI,
> >>
> >> -1 (binding) as I cannot compile the source package from source
> >>
> >> I checked:
> >> - incubating in name
> >> - signatures and hashes are fine
> >> - DISCLAIMER exits
> >> - LICENSE and NOTICE
> >> - No unexpected binary files
> >> - All ASF files have ASF headers
> >>
> >> The build fails for me as it expect it to be in a git repo. You should
> be able to compile teh source package without access to the GitHub repo.
> >>
> >> Error was:
> >> * What went wrong:
> >> A problem occurred evaluating root project 'tuweni'.
> >>> eth-reference-tests/src/test/resources/eth2.0-tests/README.md missing:
> please clone submodules (git submodule update --init --recursive)
> >>
> >> Thanks,
> >> Justin
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> >> For additional commands, e-mail: general-help@incubator.apache.org
> >>
> >
>
>