You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/06/08 01:27:44 UTC

[GitHub] [iotdb] Alima777 commented on a change in pull request #3369: [IOTDB-1426] Restructure physicalGenerator

Alima777 commented on a change in pull request #3369:
URL: https://github.com/apache/iotdb/pull/3369#discussion_r647044671



##########
File path: server/src/main/java/org/apache/iotdb/db/qp/logical/Operator.java
##########
@@ -64,22 +68,17 @@ public String toString() {
     return SQLConstant.tokenNames.get(tokenIntType);
   }
 
+  public PhysicalPlan generatePhysicalPlan(PhysicalGenerator generator)
+      throws QueryProcessException {
+    throw new LogicalOperatorException(operatorType.toString(), "");
+  }
+
   /** If you want to add new OperatorType, you must add it in the last. */
   public enum OperatorType {
-    GROUPBYTIME,
     NULL,
-    INSERT,
-    BATCHINSERT,
-    DELETE,
-    QUERY,
-    AGGREGATION,
+

Review comment:
       Just modify the order of these type to make them more maintainable.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org