You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/05/10 07:26:35 UTC
[GitHub] [incubator-eventmesh] Alonexc opened a new issue, #856: [Enhancement] Add test code for this module [eventmesh-trace-plugin]
Alonexc opened a new issue, #856:
URL: https://github.com/apache/incubator-eventmesh/issues/856
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
### Enhancement Request
Add test code for eventmesh-trace-plugin module.
### Describe the solution you'd like
module name: eventmesh-trace-api and eventmesh-trace-zipkin
located in: eventmesh-trace-plugin
Task status: ×(unfinished) / √(finished)
| Task Status | Class | Type|
| :------: | :------| :------|
| × | org/apache/eventmesh/trace/api/config/ExporterConfiguration.java | config |
| × | org/apache/eventmesh/trace/api/TracePluginFactory.java | service |
| × | org/apache/eventmesh/trace/zipkin/config/ZipkinConfiguration.java | config |
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [I] [Enhancement] Add test code for this module [eventmesh-trace-plugin] (eventmesh)
Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on issue #856:
URL: https://github.com/apache/eventmesh/issues/856#issuecomment-1883140719
Completed in https://github.com/apache/eventmesh/issues/871.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] HoffmanZheng commented on issue #856: [Enhancement] Add test code for this module [eventmesh-trace-plugin]
Posted by GitBox <gi...@apache.org>.
HoffmanZheng commented on issue #856:
URL: https://github.com/apache/incubator-eventmesh/issues/856#issuecomment-1129963051
A detailed issue #871 added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] Alonexc commented on issue #856: [Enhancement] Add test code for this module [eventmesh-trace-plugin]
Posted by GitBox <gi...@apache.org>.
Alonexc commented on issue #856:
URL: https://github.com/apache/incubator-eventmesh/issues/856#issuecomment-1129457402
@HoffmanZheng Because an issue will be closed when it is finished, and this issue will not be closed, the unit test module should be able to continuously supplement, so you need to mention another issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] Alonexc commented on issue #856: [Enhancement] Add test code for this module [eventmesh-trace-plugin]
Posted by GitBox <gi...@apache.org>.
Alonexc commented on issue #856:
URL: https://github.com/apache/incubator-eventmesh/issues/856#issuecomment-1128641111
@HoffmanZheng Hello! This issue will not be deleted,you can provide another detailed issue for your unit test and associate it with the pr you submitted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] HoffmanZheng commented on issue #856: [Enhancement] Add test code for this module [eventmesh-trace-plugin]
Posted by GitBox <gi...@apache.org>.
HoffmanZheng commented on issue #856:
URL: https://github.com/apache/incubator-eventmesh/issues/856#issuecomment-1128928265
> @HoffmanZheng Hello! This issue will not be deleted,you can provide another detailed issue for your unit test and associate it with the pr you submitted.
little confused here, why do I need another detailed issue ? To document the test code i write? IMO, the test code is already human readable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] HoffmanZheng commented on issue #856: [Enhancement] Add test code for this module [eventmesh-trace-plugin]
Posted by GitBox <gi...@apache.org>.
HoffmanZheng commented on issue #856:
URL: https://github.com/apache/incubator-eventmesh/issues/856#issuecomment-1126850127
I'd like to work on this. plz assign this to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [I] [Enhancement] Add test code for this module [eventmesh-trace-plugin] (eventmesh)
Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia closed issue #856: [Enhancement] Add test code for this module [eventmesh-trace-plugin]
URL: https://github.com/apache/eventmesh/issues/856
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org