You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@jspwiki.apache.org by Milton Taylor <mc...@gmail.com> on 2008/01/21 05:41:26 UTC

jdbc page provider...merge back to core?

I've been using the jdbc page provider for quite a long time now, and am 
also a contributor to it. It works really well, and supports different 
database flavours and connection methods in a quite flexible fashion. I 
was wondering whether it would be appropriate to merge this thing back 
into the jspwiki core repository?

Milt

Re: jdbc page provider...merge back to core?

Posted by Alex Samad <al...@samad.com.au>.
On Mon, Jan 21, 2008 at 04:13:21PM +1100, Milton Taylor wrote:
> Not sure what the connection is there...LDAP's for authentication, not for 
> storing wiki content?
ops sorry, I was thinking authentication ..
>
>
> Alex Samad wrote:
>> On Mon, Jan 21, 2008 at 03:41:26PM +1100, Milton Taylor wrote:
>>   
>>> I've been using the jdbc page provider for quite a long time now, and am 
>>> also a contributor to it. It works really well, and supports different 
>>> database flavours and connection methods in a quite flexible fashion. I 
>>> was wondering whether it would be appropriate to merge this thing back 
>>> into the jspwiki core repository?
>>>     
>> I would like to see that, wondering how hard it would be to make it point 
>> at ldap ?
>>   
>>> Milt
>>>     
>>
>>   

-- 
"The truth of that matter is, if you listen carefully, Saddam would still be in power if he were the president of the United States, and the world would be a lot better off."

	- George W. Bush
10/08/2004
St. Louis, MO
Second presidential debate

Re: jdbc page provider...merge back to core?

Posted by Milton Taylor <mc...@gmail.com>.
Not sure what the connection is there...LDAP's for authentication, not 
for storing wiki content?


Alex Samad wrote:
> On Mon, Jan 21, 2008 at 03:41:26PM +1100, Milton Taylor wrote:
>   
>> I've been using the jdbc page provider for quite a long time now, and am 
>> also a contributor to it. It works really well, and supports different 
>> database flavours and connection methods in a quite flexible fashion. I was 
>> wondering whether it would be appropriate to merge this thing back into the 
>> jspwiki core repository?
>>     
> I would like to see that, wondering how hard it would be to make it point at 
> ldap ?
>   
>> Milt
>>     
>
>   

Re: jdbc page provider...merge back to core?

Posted by Alex Samad <al...@samad.com.au>.
On Mon, Jan 21, 2008 at 03:41:26PM +1100, Milton Taylor wrote:
> I've been using the jdbc page provider for quite a long time now, and am 
> also a contributor to it. It works really well, and supports different 
> database flavours and connection methods in a quite flexible fashion. I was 
> wondering whether it would be appropriate to merge this thing back into the 
> jspwiki core repository?
I would like to see that, wondering how hard it would be to make it point at 
ldap ?
>
> Milt

-- 
"Put the 'off' button on."

	- George W. Bush
02/14/2000
giving advice to parents troubled by the graphic fare on television

Re: jdbc page provider...merge back to core?

Posted by Janne Jalkanen <Ja...@ecyrd.com>.
Heh ;-)  No worries.

/Janne

On 26 Jan 2008, at 01:23, Milton Taylor wrote:

> OK OK not *back*... I was not really putting much emphasis on the  
> significance of that word. !  (Whew)
>
> Janne Jalkanen wrote:
>>> As I said, I can't see any reason why this should not be merged  
>>> back into the mainline so that it can stay in sync with any  
>>> planned feature /api enhancements.
>>
>> It can't be merged *back*.  It's never been a part of the mainline.
>>
>> Just in the interests of scientific accuracy.
>>
>> /Janne


Re: jdbc page provider...merge back to core?

Posted by Milton Taylor <mc...@gmail.com>.
OK OK not *back*... I was not really putting much emphasis on the 
significance of that word. !  (Whew)

Janne Jalkanen wrote:
>> As I said, I can't see any reason why this should not be merged back 
>> into the mainline so that it can stay in sync with any planned 
>> feature /api enhancements.
>
> It can't be merged *back*.  It's never been a part of the mainline.
>
> Just in the interests of scientific accuracy.
>
> /Janne

Re: jdbc page provider...merge back to core?

Posted by Janne Jalkanen <Ja...@ecyrd.com>.
> As I said, I can't see any reason why this should not be merged  
> back into the mainline so that it can stay in sync with any planned  
> feature /api enhancements.

It can't be merged *back*.  It's never been a part of the mainline.

Just in the interests of scientific accuracy.

/Janne

Re: jdbc page provider...merge back to core?

Posted by Milton Taylor <mc...@gmail.com>.
The jdbc provider supports both container, user managed and dbcp pools.

As I said, I can't see any reason why this should not be merged back 
into the mainline so that it can stay in sync with any planned feature 
/api enhancements.

Janne made a comment about not being a jdbc/database wizard himself, but 
that really isn't a good enough reason! :-)  It hasn't needed any fixes 
for about a year - although I have no idea how many are using it.

Milton


Andrew Jaquith wrote:
> Really, the only issue I had was that I wanted it to use 
> container-managed database connections, and not user-managed ones. We 
> don't want to manage those things ourselves, or incur the security 
> risks of self-managed connections.
>
> Beyond that, I had no issues...
>
> On Jan 21, 2008, at 8:12, Janne Jalkanen <ja...@iki.fi> wrote:
>
>>> I've been using the jdbc page provider for quite a long time now, 
>>> and am
>>> also a contributor to it. It works really well, and supports different
>>> database flavours and connection methods in a quite flexible fashion. I
>>> was wondering whether it would be appropriate to merge this thing back
>>> into the jspwiki core repository?
>>
>> Andrew had some issues with it, but I can't recall what those were.
>> The JDBCPageProvider has never been a part of JSPWiki core, so you
>> can't exactly merge it back ;-)
>>
>> At this point, we're not merging anything which does not come with an
>> Apache license or an ASF grant...  So that would need to be resolved
>> first.  Also, it would be cool if someone took it as their job to
>> maintain it- I'm really bad at SQL stuff; I just use Hibernate and let
>> it worry about the complicated bits ;-)
>>
>> /Janne

Re: jdbc page provider...merge back to core?

Posted by Andrew Jaquith <an...@mac.com>.
Really, the only issue I had was that I wanted it to use container- 
managed database connections, and not user-managed ones. We don't want  
to manage those things ourselves, or incur the security risks of self- 
managed connections.

Beyond that, I had no issues...

On Jan 21, 2008, at 8:12, Janne Jalkanen <ja...@iki.fi> wrote:

>> I've been using the jdbc page provider for quite a long time now,  
>> and am
>> also a contributor to it. It works really well, and supports  
>> different
>> database flavours and connection methods in a quite flexible  
>> fashion. I
>> was wondering whether it would be appropriate to merge this thing  
>> back
>> into the jspwiki core repository?
>
> Andrew had some issues with it, but I can't recall what those were.
> The JDBCPageProvider has never been a part of JSPWiki core, so you
> can't exactly merge it back ;-)
>
> At this point, we're not merging anything which does not come with an
> Apache license or an ASF grant...  So that would need to be resolved
> first.  Also, it would be cool if someone took it as their job to
> maintain it- I'm really bad at SQL stuff; I just use Hibernate and let
> it worry about the complicated bits ;-)
>
> /Janne

Re: jdbc page provider...merge back to core?

Posted by Janne Jalkanen <ja...@iki.fi>.
> I've been using the jdbc page provider for quite a long time now, and am 
> also a contributor to it. It works really well, and supports different 
> database flavours and connection methods in a quite flexible fashion. I 
> was wondering whether it would be appropriate to merge this thing back 
> into the jspwiki core repository?

Andrew had some issues with it, but I can't recall what those were.
The JDBCPageProvider has never been a part of JSPWiki core, so you
can't exactly merge it back ;-)

At this point, we're not merging anything which does not come with an
Apache license or an ASF grant...  So that would need to be resolved
first.  Also, it would be cool if someone took it as their job to
maintain it- I'm really bad at SQL stuff; I just use Hibernate and let
it worry about the complicated bits ;-)

/Janne