You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2023/04/25 18:39:02 UTC

[GitHub] [superset] rusackas commented on a diff in pull request #23819: fix: Clean up docker-ephemeral-env secrets command

rusackas commented on code in PR #23819:
URL: https://github.com/apache/superset/pull/23819#discussion_r1176894198


##########
.github/workflows/docker-ephemeral-env.yml:
##########
@@ -17,14 +17,12 @@ jobs:
         id: check
         shell: bash
         run: |
-          aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
-          aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}

Review Comment:
   Did you mean to delete the top two lines? I was assuming we just need to dedent the lower section.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org