You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/01/30 02:32:32 UTC
[GitHub] [incubator-mxnet] DickJC123 opened a new issue #19805: MXNET_USE_SAFE_ACCUMULATION env var operation
DickJC123 opened a new issue #19805:
URL: https://github.com/apache/incubator-mxnet/issues/19805
## Description
Maybe I'm missing something, but is the handling of the MXNET_USE_SAFE_ACCUMULATION variable backwards (i.e. setting the variable true turns off safe accumulation)?
https://github.com/apache/incubator-mxnet/blob/3122423f3118f5ad2e278eeae97fc5a19c1feef1/src/operator/nn/layer_norm-inl.h#L124-L137
https://github.com/apache/incubator-mxnet/blob/3122423f3118f5ad2e278eeae97fc5a19c1feef1/src/operator/tensor/broadcast_reduce-inl.h#L391-L413
Tagging some that have worked or referred to this code: @sxjscience @leezu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@mxnet.apache.org
For additional commands, e-mail: issues-help@mxnet.apache.org
[GitHub] [incubator-mxnet] sxjscience commented on issue #19805: MXNET_USE_SAFE_ACCUMULATION env var operation
Posted by GitBox <gi...@apache.org>.
sxjscience commented on issue #19805:
URL: https://github.com/apache/incubator-mxnet/issues/19805#issuecomment-770143800
@DickJC123 Thanks for pointing this out. It's a bug in the general case of LayerNorm. I just checked the accelerated case and it seems to be correct there https://github.com/apache/incubator-mxnet/blob/3122423f3118f5ad2e278eeae97fc5a19c1feef1/src/operator/nn/layer_norm.cu#L348-L352 . But this is incorrect for the general case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@mxnet.apache.org
For additional commands, e-mail: issues-help@mxnet.apache.org
[GitHub] [incubator-mxnet] szha commented on issue #19805: MXNET_USE_SAFE_ACCUMULATION env var operation
Posted by GitBox <gi...@apache.org>.
szha commented on issue #19805:
URL: https://github.com/apache/incubator-mxnet/issues/19805#issuecomment-770466724
Thanks to @sxjscience for fixing the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@mxnet.apache.org
For additional commands, e-mail: issues-help@mxnet.apache.org
[GitHub] [incubator-mxnet] szha closed issue #19805: MXNET_USE_SAFE_ACCUMULATION env var operation
Posted by GitBox <gi...@apache.org>.
szha closed issue #19805:
URL: https://github.com/apache/incubator-mxnet/issues/19805
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@mxnet.apache.org
For additional commands, e-mail: issues-help@mxnet.apache.org