You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by "quantranhong1999 (via GitHub)" <gi...@apache.org> on 2023/03/20 02:47:35 UTC

[GitHub] [james-project] quantranhong1999 commented on a diff in pull request #1491: [FIX] Subscribe/unsubscribe mailbox should be per user based

quantranhong1999 commented on code in PR #1491:
URL: https://github.com/apache/james-project/pull/1491#discussion_r1141571034


##########
server/protocols/jmap-rfc-8621-integration-tests/jmap-rfc-8621-integration-tests-common/src/main/scala/org/apache/james/jmap/rfc8621/contract/MailboxChangesMethodContract.scala:
##########
@@ -1023,6 +1023,70 @@ trait MailboxChangesMethodContract {
       }
     }
 
+    @Test
+    def mailboxChangesShouldReturnUpdatedChangesWhenSubscribedOnlyPerUser(server: GuiceJamesServer): Unit = {

Review Comment:
   maybe use a subscription probe to check?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org