You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/09/13 07:16:34 UTC
[GitHub] [ignite-3] alievmirza opened a new pull request #332: IGNITE-15444 stop MetaStorageManager
alievmirza opened a new pull request #332:
URL: https://github.com/apache/ignite-3/pull/332
https://issues.apache.org/jira/browse/IGNITE-15444
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] AMashenkov merged pull request #332: IGNITE-15444 stop MetaStorageManager
Posted by GitBox <gi...@apache.org>.
AMashenkov merged pull request #332:
URL: https://github.com/apache/ignite-3/pull/332
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] sanpwc commented on a change in pull request #332: IGNITE-15444 stop MetaStorageManager
Posted by GitBox <gi...@apache.org>.
sanpwc commented on a change in pull request #332:
URL: https://github.com/apache/ignite-3/pull/332#discussion_r711931436
##########
File path: modules/metastorage-client/src/main/java/org/apache/ignite/internal/metastorage/client/CursorImpl.java
##########
@@ -101,10 +104,10 @@
cursorId -> metaStorageRaftGrpSvc.<Boolean>run(new CursorHasNextCommand(cursorId))).get();
}
catch (InterruptedException | ExecutionException e) {
- if (e.getCause().getClass().equals(NodeStoppingException.class))
+ if (e.getCause() != null && e.getCause().getClass().equals(NodeStoppingException.class))
return false;
- LOG.error("Unable to evaluate cursor hasNext command", e);
+ LOG.warn("Unable to evaluate cursor hasNext command");
Review comment:
Why it's warn and not an error?
Why we don't propagate e to log?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] alievmirza commented on a change in pull request #332: IGNITE-15444 stop MetaStorageManager
Posted by GitBox <gi...@apache.org>.
alievmirza commented on a change in pull request #332:
URL: https://github.com/apache/ignite-3/pull/332#discussion_r712109993
##########
File path: modules/metastorage-client/src/main/java/org/apache/ignite/internal/metastorage/client/CursorImpl.java
##########
@@ -101,10 +104,10 @@
cursorId -> metaStorageRaftGrpSvc.<Boolean>run(new CursorHasNextCommand(cursorId))).get();
}
catch (InterruptedException | ExecutionException e) {
- if (e.getCause().getClass().equals(NodeStoppingException.class))
+ if (e.getCause() != null && e.getCause().getClass().equals(NodeStoppingException.class))
return false;
- LOG.error("Unable to evaluate cursor hasNext command", e);
+ LOG.warn("Unable to evaluate cursor hasNext command");
Review comment:
I've changed it to debug with the exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] AMashenkov commented on a change in pull request #332: IGNITE-15444 stop MetaStorageManager
Posted by GitBox <gi...@apache.org>.
AMashenkov commented on a change in pull request #332:
URL: https://github.com/apache/ignite-3/pull/332#discussion_r710880167
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/util/IgniteSpinReadWriteLock.java
##########
@@ -0,0 +1,406 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.util;
+
+import java.util.concurrent.TimeUnit;
+import org.apache.ignite.internal.tostring.S;
+
+/**
+ * Spin read-write lock.
+ */
+public class IgniteSpinReadWriteLock {
+ /** */
+ private static final long PENDING_WLOCKS_OFFS;
+
+ /** */
+ private static final long STATE_OFFS;
+
+ /**
+ *
+ */
+ static {
+ try {
+ STATE_OFFS = GridUnsafe.objectFieldOffset(IgniteSpinReadWriteLock.class.getDeclaredField("state"));
+
+ PENDING_WLOCKS_OFFS =
+ GridUnsafe.objectFieldOffset(IgniteSpinReadWriteLock.class.getDeclaredField("pendingWLocks"));
+ }
+ catch (NoSuchFieldException e) {
+ throw new Error(e);
+ }
Review comment:
AFAIK, we thought to replace Unsafe usage with VarHandle where it is possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] AMashenkov commented on a change in pull request #332: IGNITE-15444 stop MetaStorageManager
Posted by GitBox <gi...@apache.org>.
AMashenkov commented on a change in pull request #332:
URL: https://github.com/apache/ignite-3/pull/332#discussion_r710880167
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/util/IgniteSpinReadWriteLock.java
##########
@@ -0,0 +1,406 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.util;
+
+import java.util.concurrent.TimeUnit;
+import org.apache.ignite.internal.tostring.S;
+
+/**
+ * Spin read-write lock.
+ */
+public class IgniteSpinReadWriteLock {
+ /** */
+ private static final long PENDING_WLOCKS_OFFS;
+
+ /** */
+ private static final long STATE_OFFS;
+
+ /**
+ *
+ */
+ static {
+ try {
+ STATE_OFFS = GridUnsafe.objectFieldOffset(IgniteSpinReadWriteLock.class.getDeclaredField("state"));
+
+ PENDING_WLOCKS_OFFS =
+ GridUnsafe.objectFieldOffset(IgniteSpinReadWriteLock.class.getDeclaredField("pendingWLocks"));
+ }
+ catch (NoSuchFieldException e) {
+ throw new Error(e);
+ }
Review comment:
AFAIK, we thought to replace Unsafe usage with VarHandle where it is possible.
JDK developers claims that "static final" VarHandles have no performance penalty in opposite to non-static/non-final one, which may have slightly noticible additional cost.
"static final" VarHandle will covers this case.
Would you mind to do it or create a separate ticket?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] AMashenkov commented on a change in pull request #332: IGNITE-15444 stop MetaStorageManager
Posted by GitBox <gi...@apache.org>.
AMashenkov commented on a change in pull request #332:
URL: https://github.com/apache/ignite-3/pull/332#discussion_r710886419
##########
File path: modules/raft/src/main/java/org/apache/ignite/internal/raft/Loza.java
##########
@@ -89,7 +89,7 @@ public Loza(ClusterService clusterNetSvc, Path dataPath) {
String locNodeName = clusterNetSvc.topologyService().localMember().name();
- if (nodes.stream().map(ClusterNode::name).collect(Collectors.toSet()).contains(locNodeName))
+ if (nodes.stream().map(ClusterNode::name).anyMatch(n -> n.equals(locNodeName)))
Review comment:
```suggestion
if (nodes.stream().anyMatch(n -> locNodeName.equals(n.name())))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] alievmirza commented on a change in pull request #332: IGNITE-15444 stop MetaStorageManager
Posted by GitBox <gi...@apache.org>.
alievmirza commented on a change in pull request #332:
URL: https://github.com/apache/ignite-3/pull/332#discussion_r711176991
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/util/IgniteSpinReadWriteLock.java
##########
@@ -0,0 +1,406 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.util;
+
+import java.util.concurrent.TimeUnit;
+import org.apache.ignite.internal.tostring.S;
+
+/**
+ * Spin read-write lock.
+ */
+public class IgniteSpinReadWriteLock {
+ /** */
+ private static final long PENDING_WLOCKS_OFFS;
+
+ /** */
+ private static final long STATE_OFFS;
+
+ /**
+ *
+ */
+ static {
+ try {
+ STATE_OFFS = GridUnsafe.objectFieldOffset(IgniteSpinReadWriteLock.class.getDeclaredField("state"));
+
+ PENDING_WLOCKS_OFFS =
+ GridUnsafe.objectFieldOffset(IgniteSpinReadWriteLock.class.getDeclaredField("pendingWLocks"));
+ }
+ catch (NoSuchFieldException e) {
+ throw new Error(e);
+ }
Review comment:
Thank you for pointing this out, I prefer to create ticket and add TODO https://issues.apache.org/jira/browse/IGNITE-15536
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] alievmirza commented on a change in pull request #332: IGNITE-15444 stop MetaStorageManager
Posted by GitBox <gi...@apache.org>.
alievmirza commented on a change in pull request #332:
URL: https://github.com/apache/ignite-3/pull/332#discussion_r711957180
##########
File path: modules/metastorage-client/src/main/java/org/apache/ignite/internal/metastorage/client/CursorImpl.java
##########
@@ -101,10 +104,10 @@
cursorId -> metaStorageRaftGrpSvc.<Boolean>run(new CursorHasNextCommand(cursorId))).get();
}
catch (InterruptedException | ExecutionException e) {
- if (e.getCause().getClass().equals(NodeStoppingException.class))
+ if (e.getCause() != null && e.getCause().getClass().equals(NodeStoppingException.class))
return false;
- LOG.error("Unable to evaluate cursor hasNext command", e);
+ LOG.warn("Unable to evaluate cursor hasNext command");
Review comment:
Because right after that we throw `new IgniteInternalException(e);` and exception should be handled later. In some cases exception in this method doesn't mean that there is an error, for example `InterruptedException` or `ExecutionException` with `RejectedExecutionException` as the cause.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org