[GitHub] [spark] xkrogen commented on a change in pull request #34620: [WIP][SPARK-37209][YARN][TESTS] Manually propagate `SPARK_TESTING` to ensure consistent behavior in yarn module UTs when using hadoop-2.7 and hadoop-3.2 profile

[GitBox <gi...@apache.org>]

xkrogen commented on a change in pull request #34620:
URL: https://github.com/apache/spark/pull/34620#discussion_r750475698



##########
File path: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala
##########
@@ -905,6 +905,10 @@ private[spark] class Client(
       env(ENV_DIST_CLASSPATH) = dcp
     }
 
+    sys.env.get(SPARK_TESTING).foreach { testing =>
+      env(SPARK_TESTING) = testing
+    }
+

Review comment:
       Maybe combine these two?
   
   ```suggestion
       Seq(ENV_DIST_CLASSPATH, SPARK_TESTING).foreach { envVar =>
         sys.env.get(envVar).foreach(value => env(envVar) = value)
       }
   ```
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org