[GitHub] [superset] kgabryje commented on pull request #18817: fix(sql Lab tabs): Empty SQL Lab tabs

[GitBox <gi...@apache.org>]

kgabryje commented on pull request #18817:
URL: https://github.com/apache/superset/pull/18817#issuecomment-1046922041


   Hey @AAfghahi! 2 comments:
   1. Can you please use 1 of components from `src/components/EmptyState`? I think `EmptyStateBig` will fit well here.
   2. I'd suggest we use svg instead of png. If you add the image to `/superset-frontend/src/assets/images/`, you can just pass the name of the file to the empty state component.
   
   So you can add the empty state component like this: 
   ```
   <EmptyStateBig
             title={t('Add a new tab to create SQL query')}
             image="image-name.svg"
   />
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org