You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@stratos.apache.org by ravihansa3000 <gi...@git.apache.org> on 2015/11/09 04:26:42 UTC
[GitHub] stratos pull request: Topology init
GitHub user ravihansa3000 opened a pull request:
https://github.com/apache/stratos/pull/487
Topology init
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ravihansa3000/stratos topology-init
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/stratos/pull/487.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #487
----
commit 529b231c4fd9098bc382b9843aaf5e8e770e0422
Author: Akila Perera <ra...@gmail.com>
Date: 2015-11-08T17:14:04Z
Adding initializer topic to initialize topology model, application topology model and tenant model on demand
commit cfb6641fc56fa1e8a11c9597792b269e658dfb2f
Author: Akila Perera <ra...@gmail.com>
Date: 2015-11-09T03:24:58Z
Closing STRATOS-1544: Topology Initialization Optimization
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] stratos pull request: Topology init
Posted by lahirus <gi...@git.apache.org>.
Github user lahirus commented on the pull request:
https://github.com/apache/stratos/pull/487#issuecomment-155049020
Thanks for the info Akila.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] stratos pull request: Topology init
Posted by ravihansa3000 <gi...@git.apache.org>.
Github user ravihansa3000 commented on the pull request:
https://github.com/apache/stratos/pull/487#issuecomment-155047202
I've updated PCA to use this initialization mechanism. Also updated PCA live test to verify the functionality.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] stratos pull request: Topology init
Posted by Isuru Haththotuwa <is...@apache.org>.
On Mon, Nov 9, 2015 at 1:25 PM, Gayan Gunarathne <ga...@wso2.com> wrote:
> I think we can't remove the existing periodically published complete
> topology completely until we address all the scenarios that complete
> topology event used for. This may be impact to the LB extensions as well.As
> a first step we can remain the complete topology as it is and use
> the Topology init message for the cartridge agent. Gradually we can address
> other components as well. BTW I think we can increase the complete topology
> publisher time interval with the introduction of the topology init
> functionality.
>
+1
>
> On Mon, Nov 9, 2015 at 10:24 AM, lahirus <gi...@git.apache.org> wrote:
>
>> Github user lahirus commented on the pull request:
>>
>> https://github.com/apache/stratos/pull/487#issuecomment-154924258
>>
>> Hi Imesh,
>>
>> Do we plan to remove existing, periodically published complete
>> topology?
>>
>> Thanks.
>>
>>
>> ---
>> If your project is set up for it, you can reply to this email and have
>> your
>> reply appear on GitHub as well. If your project does not have this feature
>> enabled and wishes so, or if the feature is enabled but not working,
>> please
>> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
>> with INFRA.
>> ---
>>
>
>
>
> --
>
> Gayan Gunarathne
> Technical Lead, WSO2 Inc. (http://wso2.com)
> Committer & PMC Member, Apache Stratos
> email : gayang@wso2.com | mobile : +94 775030545
>
> --
> <%2B94%20766819985>
> <%2B94%20766819985>
> Thanks and Regards,
>
> Isuru H.
> <%2B94%20766819985>
> +94 716 358 048 <%2B94%20766819985>* <http://wso2.com/>*
>
>
> * <http://wso2.com/>*
>
>
>
Re: [GitHub] stratos pull request: Topology init
Posted by Gayan Gunarathne <ga...@wso2.com>.
I think we can't remove the existing periodically published complete
topology completely until we address all the scenarios that complete
topology event used for. This may be impact to the LB extensions as well.As
a first step we can remain the complete topology as it is and use
the Topology init message for the cartridge agent. Gradually we can address
other components as well. BTW I think we can increase the complete topology
publisher time interval with the introduction of the topology init
functionality.
On Mon, Nov 9, 2015 at 10:24 AM, lahirus <gi...@git.apache.org> wrote:
> Github user lahirus commented on the pull request:
>
> https://github.com/apache/stratos/pull/487#issuecomment-154924258
>
> Hi Imesh,
>
> Do we plan to remove existing, periodically published complete
> topology?
>
> Thanks.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
--
Gayan Gunarathne
Technical Lead, WSO2 Inc. (http://wso2.com)
Committer & PMC Member, Apache Stratos
email : gayang@wso2.com | mobile : +94 775030545 <%2B94%20766819985>
[GitHub] stratos pull request: Topology init
Posted by lahirus <gi...@git.apache.org>.
Github user lahirus commented on the pull request:
https://github.com/apache/stratos/pull/487#issuecomment-154924258
Hi Imesh,
Do we plan to remove existing, periodically published complete topology?
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] stratos pull request: Topology init
Posted by ravihansa3000 <gi...@git.apache.org>.
Github user ravihansa3000 commented on the pull request:
https://github.com/apache/stratos/pull/487#issuecomment-160584010
Refer to mail thread on Stratos dev list with subject "[Dev] Publishing Complete Topology event on Demand" for more information on changes done.
Merged in 60b801144dcb05e3664353c412bc1c3fffd7c55c
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] stratos pull request: Topology init
Posted by ravihansa3000 <gi...@git.apache.org>.
Github user ravihansa3000 commented on the pull request:
https://github.com/apache/stratos/pull/487#issuecomment-155014224
We cannot remove existing, periodical complete topology event publish task. Because there might situations where CC is not active (maintenance restarts, failures etc.) and if clients publish complete topology request event, it might get ignored.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] stratos pull request: Topology init
Posted by imesh <gi...@git.apache.org>.
Github user imesh commented on the pull request:
https://github.com/apache/stratos/pull/487#issuecomment-160507388
@Akila: Did we merged this to master branch? There seems to be conflicts in this PR now.
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] stratos pull request: Topology init
Posted by imesh <gi...@git.apache.org>.
Github user imesh commented on the pull request:
https://github.com/apache/stratos/pull/487#issuecomment-154916997
Great work Akila! Few points:
- Did we remove existing complete topology publishing logic? May be this can be removed now.
- Did we update PCA to work with this model?
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] stratos pull request: Topology init
Posted by ravihansa3000 <gi...@git.apache.org>.
Github user ravihansa3000 closed the pull request at:
https://github.com/apache/stratos/pull/487
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] stratos pull request: Topology init
Posted by imesh <gi...@git.apache.org>.
Github user imesh commented on a diff in the pull request:
https://github.com/apache/stratos/pull/487#discussion_r44240370
--- Diff: components/org.apache.stratos.cloud.controller/src/main/java/org/apache/stratos/cloud/controller/internal/CloudControllerServiceComponent.java ---
@@ -176,7 +188,7 @@ private void executeCoordinatorTasks() {
componentStartUpSynchronizer.addEventListener(new ComponentActivationEventListener() {
@Override
public void activated(Component component) {
- if (component == Component.StratosManager) {
+ if (component == Component.CloudController) {
--- End diff --
What could be the reason for this change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] stratos pull request: Topology init
Posted by imesh <gi...@git.apache.org>.
Github user imesh commented on a diff in the pull request:
https://github.com/apache/stratos/pull/487#discussion_r44240380
--- Diff: components/org.apache.stratos.autoscaler/src/main/java/org/apache/stratos/autoscaler/internal/AutoscalerServiceComponent.java ---
@@ -230,7 +230,7 @@ private void executeCoordinatorTasks() throws InvalidPolicyException,
componentStartUpSynchronizer.addEventListener(new ComponentActivationEventListener() {
@Override
public void activated(Component component) {
- if (component == Component.StratosManager) {
+ if (component == Component.Autoscaler) {
--- End diff --
What could be the reason for this change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] stratos pull request: Topology init
Posted by ravihansa3000 <gi...@git.apache.org>.
Github user ravihansa3000 commented on a diff in the pull request:
https://github.com/apache/stratos/pull/487#discussion_r44256306
--- Diff: components/org.apache.stratos.autoscaler/src/main/java/org/apache/stratos/autoscaler/internal/AutoscalerServiceComponent.java ---
@@ -230,7 +230,7 @@ private void executeCoordinatorTasks() throws InvalidPolicyException,
componentStartUpSynchronizer.addEventListener(new ComponentActivationEventListener() {
@Override
public void activated(Component component) {
- if (component == Component.StratosManager) {
+ if (component == Component.Autoscaler) {
--- End diff --
I believe we had this waiting logic in CC and AS until SM is activated to schedule sync tasks since SM was waiting for complete topology and complete application model. With this optimization that is not needed anymore. Or am I missing something?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---