You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/05/06 14:26:31 UTC
[GitHub] [hudi] codope opened a new pull request, #5518: [HUDI-4052] Move HoodieMetricsCloudWatchConfig to hudi-client-common
codope opened a new pull request, #5518:
URL: https://github.com/apache/hudi/pull/5518
## What is the purpose of the pull request
Currently, HoodieMetricsCloudWatchConfig is part of hudi-aws module, while HoodieMetricConfig is part of hudi-client-common. The builder of HoodieMetricConfig uses HoodieMetricsCloudWatchConfig. When we want to use hudi write client in other engines (presto/trino), we need to include hudi-aws module because HoodieMetricsConfig initialization falls in that path. But, this bloats the presto/trino bundle, which we want to keep as light as possible.
This PR decouples the two. Let all metric configs be in client-common (e.g. prometheus and datadog configs are already there). This way we can exclude hudi-aws from the bundles.
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5518: [HUDI-4052] Move HoodieMetricsCloudWatchConfig to hudi-client-common
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5518:
URL: https://github.com/apache/hudi/pull/5518#issuecomment-1119839815
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6ab7908e49f84fef758b77ccc3167d5a97e26bb1",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8474",
"triggerID" : "6ab7908e49f84fef758b77ccc3167d5a97e26bb1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6ab7908e49f84fef758b77ccc3167d5a97e26bb1 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8474)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5518: [HUDI-4052] Move HoodieMetricsCloudWatchConfig to hudi-client-common
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5518:
URL: https://github.com/apache/hudi/pull/5518#issuecomment-1119696237
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6ab7908e49f84fef758b77ccc3167d5a97e26bb1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8474",
"triggerID" : "6ab7908e49f84fef758b77ccc3167d5a97e26bb1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6ab7908e49f84fef758b77ccc3167d5a97e26bb1 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8474)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope commented on pull request #5518: [HUDI-4052] Move HoodieMetricsCloudWatchConfig to hudi-client-common
Posted by GitBox <gi...@apache.org>.
codope commented on PR #5518:
URL: https://github.com/apache/hudi/pull/5518#issuecomment-1135893978
Closing it in favor of #5666
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope closed pull request #5518: [HUDI-4052] Move HoodieMetricsCloudWatchConfig to hudi-client-common
Posted by GitBox <gi...@apache.org>.
codope closed pull request #5518: [HUDI-4052] Move HoodieMetricsCloudWatchConfig to hudi-client-common
URL: https://github.com/apache/hudi/pull/5518
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5518: [HUDI-4052] Move HoodieMetricsCloudWatchConfig to hudi-client-common
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5518:
URL: https://github.com/apache/hudi/pull/5518#issuecomment-1119692488
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6ab7908e49f84fef758b77ccc3167d5a97e26bb1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6ab7908e49f84fef758b77ccc3167d5a97e26bb1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6ab7908e49f84fef758b77ccc3167d5a97e26bb1 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org