[jira] [Commented] (FLINK-6310) LocalExecutor#endSession() uses wrong lock for synchronization

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-6310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16062879#comment-16062879 ] 

ASF GitHub Bot commented on FLINK-6310:
---------------------------------------

GitHub user zjureel opened a pull request:

    https://github.com/apache/flink/pull/4184

    [FLINK-6310] Use lock object for synchronization

    Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your changes.
    
    - [ ] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [ ] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zjureel/flink FLINK-6310

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4184.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4184
    
----
commit 97e96414a371cb3f8d6119fd847536453c09436d
Author: zjureel <zj...@gmail.com>
Date:   2017-06-26T10:18:18Z

    [FLINK-6310] Use lock object for synchronization

----


> LocalExecutor#endSession() uses wrong lock for synchronization
> --------------------------------------------------------------
>
>                 Key: FLINK-6310
>                 URL: https://issues.apache.org/jira/browse/FLINK-6310
>             Project: Flink
>          Issue Type: Bug
>          Components: Local Runtime
>            Reporter: Ted Yu
>            Assignee: Fang Yong
>
> Here is related code:
> {code}
>   public void endSession(JobID jobID) throws Exception {
>     synchronized (LocalExecutor.class) {
>       LocalFlinkMiniCluster flink = this.flink;
> {code}
> In other places, lock field is used for synchronization:
> {code}
>   public void start() throws Exception {
>     synchronized (lock) {
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)