You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/02/20 09:44:49 UTC
[GitHub] zentol commented on a change in pull request #7719: [FLINK-10569]
Remove Instance usage in ExecutionGraphDeploymentTest
zentol commented on a change in pull request #7719: [FLINK-10569] Remove Instance usage in ExecutionGraphDeploymentTest
URL: https://github.com/apache/flink/pull/7719#discussion_r258403040
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphDeploymentTest.java
##########
@@ -182,14 +179,20 @@ public void testBuildDeploymentDescriptor() {
ExecutionJobVertex ejv = eg.getAllVertices().get(jid2);
ExecutionVertex vertex = ejv.getTaskVertices()[3];
- ExecutionGraphTestUtils.SimpleActorGatewayWithTDD instanceGateway =
- new ExecutionGraphTestUtils.SimpleActorGatewayWithTDD(
- TestingUtils.directExecutionContext(),
- blobCache);
+ SimpleAckingTaskManagerGateway taskManagerGateway = new SimpleAckingTaskManagerGateway();
+ CompletableFuture<TaskDeploymentDescriptor> tdd = new CompletableFuture<>();
+ taskManagerGateway.setSubmitConsumer(taskDeploymentDescriptor -> {
+ try {
+ taskDeploymentDescriptor.loadBigData(blobCache);
+ } catch (Exception e) {
+ e.printStackTrace();
Review comment:
Alternatively we could use a `ThrowingConsumer` here and actually catch exceptions in the `SimpleAckingTaskManagerGateway`, that logs them and returns a failed future.
Throwing an erro here is essentially undefined behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services